Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mediainfo{-gui}: 20.08 -> 20.09 #100985

Merged
merged 1 commit into from Oct 26, 2020
Merged

mediainfo{-gui}: 20.08 -> 20.09 #100985

merged 1 commit into from Oct 26, 2020

Conversation

@devhell
Copy link
Contributor

@devhell devhell commented Oct 18, 2020

This release includes a fix for #92874

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@nlewo
Copy link
Member

@nlewo nlewo commented Oct 21, 2020

@GrahamcOfBorg build mediainfo mediainfo-gui

@nlewo
Copy link
Member

@nlewo nlewo commented Oct 22, 2020

@devhell Could you please either fix or disable the build for aarch64?

@devhell
Copy link
Contributor Author

@devhell devhell commented Oct 24, 2020

@nlewo, thanks for bringing this to my attention, I'll try to investigate. I prefer not to mark a package as broken if I can. :)

@devhell
Copy link
Contributor Author

@devhell devhell commented Oct 25, 2020

The issue seemed to be with the x265 dependency, rather than mediainfo itself. Maybe it's been fixed now.

@devhell
Copy link
Contributor Author

@devhell devhell commented Oct 25, 2020

This release includes a fix for NixOS#92874
@devhell devhell force-pushed the mediainfo-20.09 branch from ca1cc5f to 8a4edf9 Oct 26, 2020
@devhell
Copy link
Contributor Author

@devhell devhell commented Oct 26, 2020

I seemingly forgot to include libmediainfo in the update. I don't have a way of replicating this build on aarch64, and therefore cannot test if the libmediainfo update fixed the issue, so I'll have to rely on what ofBorg is telling me.

@devhell
Copy link
Contributor Author

@devhell devhell commented Oct 26, 2020

@nlewo
Copy link
Member

@nlewo nlewo commented Oct 26, 2020

@devhell you need to tell which packages you want ofBorg builds.
@GrahamcOfBorg build mediainfo mediainfo-gui

@devhell
Copy link
Contributor Author

@devhell devhell commented Oct 26, 2020

Sorry, @nlewo I was under the impression it would build everything in the PR if not specified?

@nlewo
Copy link
Member

@nlewo nlewo commented Oct 26, 2020

It's actually pretty difficult to determine which attributes need to be rebuild from a diff;) See the README of https://github.com/NixOS/ofborg for more explanations.

@devhell
Copy link
Contributor Author

@devhell devhell commented Oct 26, 2020

Thanks for the info. I'll remember that. Also, the build is succeeding now on aarch64 ;)

@nlewo
Copy link
Member

@nlewo nlewo commented Oct 26, 2020

Yeah, cool! Thank you ;)

@nlewo nlewo merged commit a7a1447 into NixOS:master Oct 26, 2020
18 of 20 checks passed
@devhell
Copy link
Contributor Author

@devhell devhell commented Oct 26, 2020

Thank you too!

@devhell devhell deleted the mediainfo-20.09 branch Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants