Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xrdc: add option to specify a log file location #100986

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@Laserath
Copy link

@Laserath Laserath commented Oct 18, 2020

xrdc: add option to specify a log file location
adds the services.xrdc.logFile attribute to specify the location to use for the service logs
defaults to off (/dev/null) which is the current behavior

Motivation for this change

I'm having trouble getting xrdp working with Pantheon and not having logging for xrdp is making it very difficult to debug

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
adds the services.xrdc.logFile attribute to specify the location to use
for the service logs
defaults to off (/dev/null) which is the current behavior
@Laserath Laserath changed the title adding logging option for xrdp xrdc: add option to specify a log file location Oct 18, 2020
@stale
Copy link

@stale stale bot commented Apr 18, 2021

I marked this as stale due to inactivity. → More info

hrhino
hrhino approved these changes Jun 30, 2021
default = "/dev/null";
example = "/var/log/xrdp-sesman.log";
description = ''
location for xrdp to write its logs
Copy link
Contributor

@hrhino hrhino Jun 30, 2021

could be something more like "Location where xrdp writes its logs." with capitals/period but

@stale stale bot removed the 2.status: stale label Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants