Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microaeson: Unbreak via jailbreak #101008

Merged

Conversation

@markus1189
Copy link
Contributor

@markus1189 markus1189 commented Oct 18, 2020

Motivation for this change

Unbreak the microaeson package by relaxing the pretty tight version bounds using doJailbreak

Can hopefully be removed with haskell-hvr/microaeson#4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@markus1189 markus1189 requested a review from cdepillabout as a code owner Oct 18, 2020
Copy link
Member

@cdepillabout cdepillabout left a comment

Looks like it builds fine, thanks for fixing this up and leaving a PR link in the comments.

This isn't too important, but in the future, the commit message should be something like haskellPackages.microaeson: Unbreak via jailbreak so that things like @GrahamcOfBorg know that microaeson can be found in haskellPackages, instead of on the top-level.

@cdepillabout cdepillabout merged commit 8a1114d into NixOS:haskell-updates Oct 19, 2020
16 checks passed
16 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9fca187"; rev="9fca1878f24fe46a722d626864cf77674b84b51a"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9fca187"; rev="9fca1878f24fe46a722d626864cf77674b84b51a"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9fca187"; rev="9fca1878f24fe46a722d626864cf77674b84b51a"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9fca187"; rev="9fca1878f24fe46a722d626864cf77674b84b51a"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9fca187"; rev="9fca1878f24fe46a722d626864cf77674b84b51a"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9fca187"; rev="9fca1878f24fe46a722d626864cf77674b84b51a"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9fca187"; rev="9fca1878f24fe46a722d626864cf77674b84b51a"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
markus1189 added a commit to markus1189/nixpkgs that referenced this pull request Oct 19, 2020
With NixOS#101008, this package builds
successfully and passes all tests as well.
@markus1189 markus1189 deleted the markus1189:haskell-unbreak-microaeson branch Oct 19, 2020
markus1189 added a commit to markus1189/nixpkgs that referenced this pull request Oct 19, 2020
With NixOS#101008, this package builds
successfully and passes all tests as well.
markus1189 added a commit to markus1189/nixpkgs that referenced this pull request Oct 19, 2020
With NixOS#101008, this package builds
successfully and passes all tests as well.
peti added a commit that referenced this pull request Oct 23, 2020
With #101008, this package builds
successfully and passes all tests as well.
peti added a commit that referenced this pull request Oct 23, 2020
With #101008, this package builds
successfully and passes all tests as well.
peti added a commit that referenced this pull request Oct 23, 2020
With #101008, this package builds
successfully and passes all tests as well.
marcus7070 added a commit to marcus7070/nixpkgs that referenced this pull request Nov 22, 2020
With NixOS#101008, this package builds
successfully and passes all tests as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants