Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iSCSI: add various modules and a test #101015

Closed
wants to merge 5 commits into from

Conversation

@ajs124
Copy link
Member

@ajs124 ajs124 commented Oct 18, 2020

Motivation for this change

This builds on top of #97793, to provide some iSCSI stuff.

Not sure if and how useful this would be to anyone, tbh.

cc @zaninime

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ajs124
Copy link
Member Author

@ajs124 ajs124 commented Oct 18, 2020

The test seems to fail currently, which is weird, because it succeeded in my tree. We're still on 20.03, though.

@ajs124
Copy link
Member Author

@ajs124 ajs124 commented Oct 28, 2020

In any case, I'm going to close this, for now. The code is here, if you want it, and I have worked a bit on it since and might continue to work it, but I kind of doubt anyone will be interested in this. If you are, for some reason, just comment below.

@ajs124 ajs124 closed this Oct 28, 2020
@ajs124 ajs124 deleted the helsinki-systems:init/mod/openiscsi branch Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant