Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.pycairo: drop xlibs #101022

Merged
merged 1 commit into from Oct 20, 2020
Merged

python3.pkgs.pycairo: drop xlibs #101022

merged 1 commit into from Oct 20, 2020

Conversation

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 18, 2020

Motivation for this change

They do not seem to be needed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jtojnar jtojnar changed the base branch from staging to master Oct 18, 2020
@jtojnar jtojnar changed the base branch from master to staging Oct 18, 2020
@jtojnar jtojnar changed the title pycairo drop xlibs python3.pkgs.pycairo: drop xlibs Oct 18, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 18, 2020

This is there since the beginning 4d0fe8a. x11 was later replaced with the wrapper 21e3ff6#diff-13323b2d8dae38f7642f14099de0572dfcbbff6fd42cfad121e4ef4c57f3dda9.

@jtojnar jtojnar force-pushed the pycairo-drop-xlibs branch 2 times, most recently from 15e070b to e071a7d Oct 19, 2020
* drop unneeded xlibs dependency
* correct license
* do not use pkgconfig alias
* use pytestCheckHook
* format
@jtojnar jtojnar merged commit d4975d2 into NixOS:staging Oct 20, 2020
17 checks passed
17 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="17739fa"; rev="17739fa57026d7621654b56b9a1438e8de51bd38"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="17739fa"; rev="17739fa57026d7621654b56b9a1438e8de51bd38"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="17739fa"; rev="17739fa57026d7621654b56b9a1438e8de51bd38"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="17739fa"; rev="17739fa57026d7621654b56b9a1438e8de51bd38"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="17739fa"; rev="17739fa57026d7621654b56b9a1438e8de51bd38"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="17739fa"; rev="17739fa57026d7621654b56b9a1438e8de51bd38"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="17739fa"; rev="17739fa57026d7621654b56b9a1438e8de51bd38"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jtojnar jtojnar deleted the pycairo-drop-xlibs branch Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants