Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pyaftership: init at 0.1.2 #101033

merged 2 commits into from Oct 19, 2020


Copy link

@JamieMagee JamieMagee commented Oct 18, 2020

Motivation for this change

Support the aftership component in home assistant

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
@JamieMagee JamieMagee requested review from FRidh and jonringer as code owners Oct 18, 2020
catern approved these changes Oct 18, 2020
Copy link

@mweinelt mweinelt commented Oct 19, 2020

Result of nixpkgs-review pr 101033 1

2 packages built:
  • python37Packages.pyaftership
  • python38Packages.pyaftership

mweinelt added a commit that referenced this issue Oct 19, 2020
pythonPackages.pyaftership: init at 0.1.2
@mweinelt mweinelt merged commit 4dca83e into NixOS:master Oct 19, 2020
19 checks passed
@JamieMagee JamieMagee deleted the pyaftership branch Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants