Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.hydrus: init at 413 #101034

Merged
merged 1 commit into from Oct 19, 2020
Merged

pythonPackages.hydrus: init at 413 #101034

merged 1 commit into from Oct 19, 2020

Conversation

@evanjs
Copy link
Member

@evanjs evanjs commented Oct 18, 2020

Motivation for this change

Hydrus: "A personal booru-style media tagger that can import files and tags from your hard drive and popular websites. Content can be shared with other users via user-run servers."

Closes #96572


Related: imgbrd-grabber via #67632.

Basic navigation, settings changes, etc., can be tested by following the instructions here.
I am able to run both the client and server, create an initial superuser account, and verify the connection via services -> review services -> remote


Things done
  • Add hydrus to pythonPackages
  • Add hydrus to all-packages
  • Patch binaries (e.g. swfrender, etc. -- normally found in bin) to use binaries sourced from nixpkgs

cc @deliciouslytyped @rendeko

@evanjs evanjs requested review from FRidh and jonringer as code owners Oct 18, 2020
@evanjs evanjs force-pushed the hydrus/init branch 2 times, most recently from 1732cba to 76c5464 Oct 18, 2020
@evanjs evanjs changed the title pythonPackages/hydrus: init at 413 pythonPackages.hydrus: init at 413 Oct 18, 2020
catern
catern approved these changes Oct 18, 2020
Copy link
Contributor

@catern catern left a comment

Seems to build and run fine

pkgs/development/python-modules/hydrus/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/hydrus/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
];

# tests require a graphical session
doCheck = false;
Copy link
Contributor

@catern catern Oct 18, 2020

Not all of them require a graphical session right? It looks like there are at least some which just run against the server, maybe you can try running those?

Copy link
Member Author

@evanjs evanjs Oct 19, 2020

While a dry nosetest run shows 68/90 failing, I can only manage to get 11 passing when excluding the failing tests/modules/whatever.

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 101034 1

1 package built:
  • hydrus

@jonringer jonringer merged commit 154fa4d into NixOS:master Oct 19, 2020
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants