Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] python3Package.pytest-flask: remove support for python 2.7 #101036

Merged
merged 1 commit into from Oct 19, 2020

Conversation

@jfroche
Copy link
Contributor

@jfroche jfroche commented Oct 18, 2020

As stated in its changelog [1], python 2.7 is no longer supported.

[1] https://github.com/pytest-dev/pytest-flask/blob/master/docs/changelog.rst

Backport #100525
ZHF: #97479
@NixOS/nixos-release-managers
Fixes https://hydra.nixos.org/build/127652828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
As stated in its changelog [1], python 2.7 is no longer supported.

[1] https://github.com/pytest-dev/pytest-flask/blob/master/docs/changelog.rst

(cherry picked from commit e07cf5d)
@jfroche jfroche requested review from FRidh and jonringer as code owners Oct 18, 2020
@jfroche
Copy link
Contributor Author

@jfroche jfroche commented Oct 18, 2020

Result of nixpkgs-review pr 101036 1

5 packages built:
  • flexget
  • python37Packages.flask-restx
  • python37Packages.pytest-flask
  • python38Packages.flask-restx
  • python38Packages.pytest-flask

@jfroche jfroche changed the title python3Package.pytest-flask: remove support for python 2.7 [20.09] python3Package.pytest-flask: remove support for python 2.7 Oct 18, 2020
@ofborg ofborg bot requested a review from vanschelven Oct 18, 2020
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 101036 1

5 packages built:
  • flexget
  • python37Packages.flask-restx
  • python37Packages.pytest-flask
  • python38Packages.flask-restx
  • python38Packages.pytest-flask

@jonringer jonringer merged commit c8a4fd8 into NixOS:release-20.09 Oct 19, 2020
16 checks passed
16 checks passed
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d63a350"; rev="d63a350bd79cf72856872bbc55ff150594911072"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d63a350"; rev="d63a350bd79cf72856872bbc55ff150594911072"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d63a350"; rev="d63a350bd79cf72856872bbc55ff150594911072"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d63a350"; rev="d63a350bd79cf72856872bbc55ff150594911072"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d63a350"; rev="d63a350bd79cf72856872bbc55ff150594911072"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d63a350"; rev="d63a350bd79cf72856872bbc55ff150594911072"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d63a350"; rev="d63a350bd79cf72856872bbc55ff150594911072"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants