Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: pyxdg: 0.26 -> 0.27 #101045

Merged
merged 1 commit into from Dec 8, 2020
Merged

Conversation

@mjlbach
Copy link
Contributor

@mjlbach mjlbach commented Oct 19, 2020

Motivation for this change

Bump pyxdg and remove need for external patch (upstreamed),

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@mweinelt mweinelt left a comment

Thanks for contributing. I've added some remarks on how we can improve the quality of the package if you're interested.

pkgs/development/python-modules/pyxdg/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyxdg/default.nix Outdated Show resolved Hide resolved
@mjlbach mjlbach force-pushed the feature/bump_pyxdg branch 3 times, most recently from 4bb0ca6 to ed41643 Oct 19, 2020
sha256 = "17cjax546rkqv5kvwczjqjdd6vmlvcxjanz0296dlfq23j2wbx63";
})
];
#Currently these tests fail (4 errors, 4 warnings)
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 27, 2020

Please remove the commented out code.

Copy link
Contributor Author

@mjlbach mjlbach Nov 27, 2020

Done, the tests are still failing and I've removed references to the tests.

@mjlbach mjlbach force-pushed the feature/bump_pyxdg branch 3 times, most recently from acbe2c4 to c64c780 Nov 27, 2020
@mjlbach mjlbach force-pushed the feature/bump_pyxdg branch from c64c780 to 40389df Nov 27, 2020
@mjlbach
Copy link
Contributor Author

@mjlbach mjlbach commented Nov 27, 2020

@SuperSandro2000 @mweinelt Unless we want to try to figure out why the tests are failing, I think this is ready to merge.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 8, 2020

Result of nixpkgs-review pr 101045 run on x86_64-darwin 1

11 packages marked as broken and skipped:
  • bedup
  • dasher
  • gammastep
  • lxqt.obconf-qt
  • python37Packages.bedup
  • python38Packages.bedup
  • redshift
  • redshift-wlr
  • run-scaled
  • setzer
  • zim
6 packages failed to build:
  • deluge (deluge-2_x)
  • deluge-1_x
  • khal
  • linkchecker
  • stig
  • styx
12 packages built:
  • cligh
  • curseradio
  • gitAndTools.pass-git-helper
  • hamster
  • mimeo
  • python27Packages.pyxdg
  • python37Packages.bugwarrior
  • python37Packages.pyxdg
  • python37Packages.suseapi
  • python38Packages.bugwarrior
  • python38Packages.pyxdg
  • python38Packages.suseapi

Going to fix those build failures in another PR.

@SuperSandro2000 SuperSandro2000 merged commit 250ce0f into NixOS:master Dec 8, 2020
19 checks passed
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 8, 2020

Result of nixpkgs-review pr 101045 run on x86_64-linux 1

17 packages failed to build:
  • beets
  • chromium
  • dasher
  • orca (gnome3.orca)
  • google-chrome
  • google-chrome-beta
  • google-chrome-dev
  • ib-controller
  • khal
  • pantheon.elementary-session-settings
  • python37Packages.spyder
  • spyder (python38Packages.spyder)
  • rofimoji
  • run-scaled
  • ungoogled-chromium
  • xpra
  • zim
50 packages built:
  • bedup (python38Packages.bedup)
  • bubblemail
  • caffeine-ng
  • cligh
  • curseradio
  • deluge (deluge-2_x)
  • deluge-1_x
  • dockbarx
  • evdevremapkeys
  • gammastep
  • gitAndTools.pass-git-helper
  • hamster
  • ibus-engines.uniemoji
  • kazam
  • kupfer
  • linkchecker
  • lxqt.obconf-qt
  • mailnag
  • mailnagWithPlugins
  • mididings
  • mimeo
  • obconf
  • openbox
  • paperwork
  • pitivi
  • python27Packages.pyxdg
  • python37Packages.bedup
  • python37Packages.bugwarrior
  • python37Packages.pyxdg
  • python37Packages.suseapi
  • python38Packages.bugwarrior
  • python38Packages.pyxdg
  • python38Packages.suseapi
  • qtile
  • rapid-photo-downloader
  • redshift
  • redshift-plasma-applet
  • redshift-wlr
  • selinux-sandbox
  • setzer
  • speechd
  • stig
  • styx
  • tartube
  • todoman
  • ulauncher
  • xdgmenumaker
  • xfce.catfish
  • xfce.xfce4-dockbarx-plugin (xfce.xfce4_dockbarx_plugin)
  • xflux-gui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants