Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imgbrd-grabber: init at 7.3.2 #101048

Merged
merged 4 commits into from Nov 23, 2020
Merged

imgbrd-grabber: init at 7.3.2 #101048

merged 4 commits into from Nov 23, 2020

Conversation

@evanjs
Copy link
Member

@evanjs evanjs commented Oct 19, 2020

Motivation for this change

imgbrd-grabber: "Very customizable imageboard/booru downloader with powerful filenaming features."

Closes #67632

Can be sourced by Hydrus once #101034 is merged.

Things Done

I only considered the Linux application but I doubt it would be much work to get things working on macOS.

Notes

I initially tried to build from source, but the build uses npm install for sites module.
Additionally, the package.json does not contain a version (required for node2nix), so I settled on packaging the binary application for now.

Update:

I have pushed an expression that builds the application from source.


Bugs

With 7.3.2, Grabber-cli crashes when used.
This is solved by Bionus/imgbrd-grabber@3814631.
This has not yet been merged, and the patch does not apply cleanly on top of 7.3.2.
For more information, see the issue.


cc @klorophatu @toyo-chi @hyarsan @deliciouslytyped

@evanjs
Copy link
Member Author

@evanjs evanjs commented Oct 19, 2020

Think I figured out what was wrong with the source builds.
Cleaning up some things before I update this PR

@evanjs
Copy link
Member Author

@evanjs evanjs commented Oct 20, 2020

Changes have been pushed.
I'll rebase and squash once they have been reviewed. Wanted to leave the binary expression up until then for comparison or etc.

@evanjs
Copy link
Member Author

@evanjs evanjs commented Oct 21, 2020

@jonringer Any thoughts on the transition from binary -> source builds here?
@Bionus recommended using the package.sh script, which seemed fine after I patched the shebang and rsync binary.

Sort of paranoid on whether I'm missing anything else, or if the post* stages could be any more idiomatic, etc.

@evanjs evanjs requested a review from jonringer Oct 28, 2020
@Artturin
Copy link
Member

@Artturin Artturin commented Nov 5, 2020

Result of nixpkgs-review pr 101048 1

1 package built:
  • imgbrd-grabber

did a quick test and it seems to work as well as it did on arch

@RaghavSood
Copy link
Member

@RaghavSood RaghavSood commented Nov 23, 2020

Result of nixpkgs-review pr 101048 1

1 package built:
  • imgbrd-grabber

@RaghavSood RaghavSood merged commit 0a90b97 into NixOS:master Nov 23, 2020
19 checks passed
@Artturin
Copy link
Member

@Artturin Artturin commented Nov 26, 2020

just noticed that you forgot to add the meta section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants