Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goreleaser: init at 0.145.0 #101049

Merged
merged 3 commits into from Nov 27, 2020
Merged

goreleaser: init at 0.145.0 #101049

merged 3 commits into from Nov 27, 2020

Conversation

sarcasticadmin
Copy link
Member

Motivation for this change

Currently leveraging goreleaser for releasing go tools.

Pigging backing initial work from #82986 but it looks like its outdated. @c0deaddict FYI

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from c0deaddict and kalbasit October 19, 2020 04:18
IvarWithoutBones
IvarWithoutBones approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binary works, diff LGTM 👍

Result of nixpkgs-review pr 101049 1

1 package built:
  • goreleaser

c0deaddict
c0deaddict approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@c0deaddict c0deaddict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me! Closed my old PR.

@c0deaddict c0deaddict mentioned this pull request Oct 23, 2020
Closed
10 tasks
endocrimes
endocrimes approved these changes Oct 23, 2020
View reviewed changes
pkgs/tools/misc/goreleaser/default.nix Outdated Show resolved Hide resolved
@sarcasticadmin
Copy link
Member Author

Thanks everyone for the approvals and feedback! I went ahead and made the appropriate updates. If theres anything else just let me know.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101049 run on x86_64-linux 1

1 package built:
  • goreleaser

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101049 run on x86_64-darwin 1

1 package built:
  • goreleaser

@SuperSandro2000 SuperSandro2000 merged commit 81fb32a into NixOS:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@c0deaddict c0deaddict c0deaddict approved these changes

@endocrimes endocrimes endocrimes approved these changes

@IvarWithoutBones IvarWithoutBones IvarWithoutBones approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sarcasticadmin @SuperSandro2000 @c0deaddict @endocrimes @IvarWithoutBones