Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goreleaser: init at 0.145.0 #101049

Merged
merged 3 commits into from Nov 27, 2020
Merged

Conversation

@sarcasticadmin
Copy link
Member

@sarcasticadmin sarcasticadmin commented Oct 19, 2020

Motivation for this change

Currently leveraging goreleaser for releasing go tools.

Pigging backing initial work from #82986 but it looks like its outdated. @c0deaddict FYI

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@IvarWithoutBones IvarWithoutBones left a comment

Binary works, diff LGTM 👍

Result of nixpkgs-review pr 101049 1

1 package built:
  • goreleaser

Copy link
Contributor

@c0deaddict c0deaddict left a comment

Nice, looks good to me! Closed my old PR.

@c0deaddict c0deaddict mentioned this pull request Oct 23, 2020
10 tasks
pkgs/tools/misc/goreleaser/default.nix Outdated Show resolved Hide resolved
@sarcasticadmin
Copy link
Member Author

@sarcasticadmin sarcasticadmin commented Oct 24, 2020

Thanks everyone for the approvals and feedback! I went ahead and made the appropriate updates. If theres anything else just let me know.

@ofborg ofborg bot requested review from c0deaddict and endocrimes Oct 24, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

Result of nixpkgs-review pr 101049 run on x86_64-linux 1

1 package built:
  • goreleaser

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

Result of nixpkgs-review pr 101049 run on x86_64-darwin 1

1 package built:
  • goreleaser

@SuperSandro2000 SuperSandro2000 merged commit 81fb32a into NixOS:master Nov 27, 2020
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants