Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.stan: Mark as not broken and enable tests #101052

Merged
merged 1 commit into from Oct 19, 2020

Conversation

@markus1189
Copy link
Contributor

@markus1189 markus1189 commented Oct 19, 2020

Motivation for this change

With #101008, this package builds
successfully and passes all tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
With NixOS#101008, this package builds
successfully and passes all tests as well.
@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Oct 19, 2020

Looks like stan is compiling now, thanks for fixing this up!

@cdepillabout cdepillabout merged commit bce4045 into NixOS:haskell-updates Oct 19, 2020
16 checks passed
@markus1189 markus1189 deleted the haskell-unbreak-stan branch Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants