Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visidata: 1.5.2 -> 2.0.1 #101056

Merged
merged 1 commit into from Oct 19, 2020
Merged

visidata: 1.5.2 -> 2.0.1 #101056

merged 1 commit into from Oct 19, 2020

Conversation

@teto
Copy link
Contributor

@teto teto commented Oct 19, 2020

also added way to open .pcap file.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
also added way to open .pcap file.
@ofborg ofborg bot requested a review from 7c6f434c Oct 19, 2020
@7c6f434c 7c6f434c merged commit 0a2d2f9 into NixOS:master Oct 19, 2020
19 of 20 checks passed
@teto teto deleted the visidata branch Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants