Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

julia-mono: 0.018 -> 0.022 #101062

Merged
merged 1 commit into from Oct 19, 2020
Merged

julia-mono: 0.018 -> 0.022 #101062

merged 1 commit into from Oct 19, 2020

Conversation

@suhr
Copy link
Contributor

@suhr suhr commented Oct 19, 2020

Motivation for this change

Rebase of #100386.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@suhr suhr changed the title v0.022 julia-mono: 0.018 -> 0.022 Oct 19, 2020
@suhr suhr mentioned this pull request Oct 19, 2020
10 tasks
@garbas garbas merged commit 2c5efec into NixOS:master Oct 19, 2020
19 checks passed
19 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
julia-mono, julia-mono.passthru.tests on aarch64-linux Unexpected error: command failed with exit code 102
Details
@ofborg[bot]
julia-mono, julia-mono.passthru.tests on x86_64-linux Unexpected error: command failed with exit code 102
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d6ade09"; rev="d6ade09d5fc6787e5b0cf2a224e52915fab86670"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d6ade09"; rev="d6ade09d5fc6787e5b0cf2a224e52915fab86670"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d6ade09"; rev="d6ade09d5fc6787e5b0cf2a224e52915fab86670"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d6ade09"; rev="d6ade09d5fc6787e5b0cf2a224e52915fab86670"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d6ade09"; rev="d6ade09d5fc6787e5b0cf2a224e52915fab86670"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d6ade09"; rev="d6ade09d5fc6787e5b0cf2a224e52915fab86670"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d6ade09"; rev="d6ade09d5fc6787e5b0cf2a224e52915fab86670"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@suhr suhr deleted the julia-mono-22 branch Oct 20, 2020
@xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Oct 22, 2020

I get a hash mismatch when trying to build this..

@garbas
Copy link
Contributor

@garbas garbas commented Oct 22, 2020

@xaverdh weird, it worked for me 3 days ago. I'll submit a fix

@garbas garbas mentioned this pull request Oct 22, 2020
10 tasks
@xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Oct 22, 2020

@xaverdh weird, it worked for me 3 days ago. I'll submit a fix

That probably means the output is nondeterministic, so just updating the hash will not be enough..

@garbas
Copy link
Contributor

@garbas garbas commented Oct 22, 2020

@xaverdh did this happen already in the past with julia-mono package?

@xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Oct 22, 2020

not sure.. in principle people with push access to the upstream repo can modify the release tarballs / upload new ones I think (would personally consider this very unfriendly from upstream), so maybe that's what happened. In this case is probably is enough to update the hash.

@xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Oct 22, 2020

Also thinks like caching can mask nondeterminism issues / changed upstream sources or data, because you will just just download the old version from the cache (when the hash was still valid)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants