Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/caddy: remove services.caddy.agree #101067

Merged
merged 1 commit into from Oct 30, 2020

Conversation

@deviant
Copy link
Member

@deviant deviant commented Oct 19, 2020

This option is no longer referenced anywhere as of #99371.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This option is no longer referenced anywhere as of NixOS#99371.
@alyssais
Copy link
Member

@alyssais alyssais commented Oct 26, 2020

Shouldn’t the caddy 2 module still require this (or check security.acme.acceptTerms, which would probably make more sense that a sperrte option meaning the same thing)? It looks like it will still request certificates from letsencrypt automatically by default? cc @sephii

@deviant
Copy link
Member Author

@deviant deviant commented Oct 26, 2020

Nope! It's unconditional now. I believe this was introduced in this commit, although I'm not entirely certain.

@worldofpeace worldofpeace merged commit 214af51 into NixOS:master Oct 30, 2020
17 checks passed
@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Oct 30, 2020

A port to stable for this would also be nice

@deviant
Copy link
Member Author

@deviant deviant commented Oct 30, 2020

@deviant deviant deleted the remove-caddy-agree branch Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants