Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.hindent: unbreak by fetching more recent source #101082

Closed
wants to merge 12 commits into from

Conversation

@markus1189
Copy link
Contributor

@markus1189 markus1189 commented Oct 19, 2020

Motivation for this change

Hindent fails to build due to a missing MonadFail instance, which is already present at HEAD, but not yet released.

There is an open issue for a release here: mihaimaruseac/hindent#570

Meanwhile, we can fix hindent by fetching a more recent version.

Also, enable the tests, because they pass.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
peti and others added 9 commits Oct 17, 2020
This update was generated by hackage2nix v2.15.5-21-g59d310e from Hackage revision
commercialhaskell/all-cabal-hashes@2a9259d.
This update was generated by hackage2nix v2.15.5-22-g3b35a5f from Hackage revision
commercialhaskell/all-cabal-hashes@d64cb5e.
This update was generated by hackage2nix v2.15.5-22-g3b35a5f from Hackage revision
commercialhaskell/all-cabal-hashes@80ba8be.
This update was generated by hackage2nix v2.15.5-25-gc299817 from Hackage revision
commercialhaskell/all-cabal-hashes@1da79df.
With NixOS#101008, this package builds
successfully and passes all tests as well.
haskellPackages.stan: Mark as not broken and enable tests
This update was generated by hackage2nix v2.15.5-25-gc299817 from Hackage revision
commercialhaskell/all-cabal-hashes@19db652.
@markus1189
Copy link
Contributor Author

@markus1189 markus1189 commented Oct 20, 2020

peti and others added 2 commits Oct 21, 2020
@peti peti force-pushed the haskell-updates branch 2 times, most recently from d060d81 to c90c206 Oct 23, 2020
@peti peti force-pushed the haskell-updates branch 3 times, most recently from 87295a3 to e240cce Nov 6, 2020
@@ -630,14 +630,16 @@ self: super: {

# Make elisp files available at a location where people expect it.
hindent = (overrideCabal super.hindent (drv: {
# 2020-10-19: needs MonadFail fix, see https://github.com/mihaimaruseac/hindent/issues/570
patches = [ ./patches/hindent-monadfail.patch ];
Copy link
Member

@peti peti Nov 6, 2020

Please fetch that patch from Github instead of checking it into our repository.

@peti peti force-pushed the haskell-updates branch 3 times, most recently from a7d0cd6 to d1e684c Nov 6, 2020
@markus1189 markus1189 closed this Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants