Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plata-theme: 0.9.8 -> 0.9.9 #101093

Merged
merged 2 commits into from Aug 12, 2021
Merged

plata-theme: 0.9.8 -> 0.9.9 #101093

merged 2 commits into from Aug 12, 2021

Conversation

@tadfisher
Copy link
Contributor

@tadfisher tadfisher commented Oct 19, 2020

Motivation for this change
  • Drop unneeded buildInputs as this derivation produces static files with no binary dependencies.
  • Add gtk2 and gtk-engine-murrine to propagatedUserEnvPkgs for GTK2 support at runtime.
  • Bump package version to 0.9.9.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
buildInputs = [
gdk-pixbuf
librsvg
Copy link
Contributor

@jtojnar jtojnar Oct 30, 2020

From reading https://gitlab.com/tista500/plata-theme#installation-from-git-source, I would expect librsvg to be needed for generating images or something. So it should probably go to nativeBuildInputs.

But here it looks like gdk-pixbuf is needed as a library: https://gitlab.com/tista500/plata-theme/-/blob/1dd0953f1d6a35777388d39f46e2428c038042be/configure.ac#L42

Copy link
Contributor Author

@tadfisher tadfisher Feb 5, 2021

librsvg is not needed or mentioned anywhere in the repo; inkscape is used to generate images.

gdk-pixbuf seems to be a sanity check, there's not really a reason to require it to build the theme. I added it to nativeBuildInputs just in case it causes an error.

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 30, 2020

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 25, 2020

Result of nixpkgs-review pr 101093 run on x86_64-linux 1

1 package built:
  • plata-theme

@IvarWithoutBones
Copy link
Contributor

@IvarWithoutBones IvarWithoutBones commented Jan 31, 2021

@tadfisher would you mind rebasing this? :)

@tadfisher
Copy link
Contributor Author

@tadfisher tadfisher commented Feb 5, 2021

@IvarWithoutBones Rebased, thanks.

librsvg
# GTK2 engines must be on the system path at runtime to be loaded.
propagatedUserEnvPkgs = [
gtk2
Copy link
Member

@Artturin Artturin Aug 3, 2021

afaik only gtk-engine-murrine needs to be in propagatedUserEnvPkgs, if so gtk2 should be in buildInputs

Copy link
Contributor

@romildo romildo Aug 3, 2021

And probably gtk_engines instead of gtk2.

@Artturin Artturin merged commit b08ed41 into NixOS:master Aug 12, 2021
22 of 23 checks passed
22 of 23 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
tests
Details
@github-actions[bot]
labels
Details
@github-actions[bot]
action
Details
@ofborg[bot]
plata-theme, plata-theme.passthru.tests on x86_64-darwin
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
ofborg-eval ^.^!
Details
@ofborg[bot]
ofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
ofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
ofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d212d19"; rev="d212d19581918fd73cff2fce12b8afba39d6c370"; } ./pkgs/t
Details
@ofborg[bot]
ofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
ofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d212d19"; rev="d212d19581918fd73cff2fce12b8afba39d6c370"; } ./nixos/
Details
@ofborg[bot]
ofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d212d19"; rev="d212d19581918fd73cff2fce12b8afba39d6c370"; } ./nixos/
Details
@ofborg[bot]
ofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d212d19"; rev="d212d19581918fd73cff2fce12b8afba39d6c370"; } ./nixos/
Details
@ofborg[bot]
ofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d212d19"; rev="d212d19581918fd73cff2fce12b8afba39d6c370"; } ./pkgs/t
Details
@ofborg[bot]
ofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d212d19"; rev="d212d19581918fd73cff2fce12b8afba39d6c370"; } ./pkgs/t
Details
@ofborg[bot]
ofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d212d19"; rev="d212d19581918fd73cff2fce12b8afba39d6c370"; } ./pkgs/t
Details
@ofborg[bot]
ofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
ofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
ofborg-eval-started Evaluation started
Details
@ofborg[bot]
plata-theme, plata-theme.passthru.tests on aarch64-linux Success
Details
@ofborg[bot]
plata-theme, plata-theme.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants