Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextinspace: init at 1.0.2 #101102

Closed
wants to merge 2 commits into from
Closed

nextinspace: init at 1.0.2 #101102

wants to merge 2 commits into from

Conversation

@penguwin
Copy link
Member

@penguwin penguwin commented Oct 19, 2020

Motivation for this change

bring the nextinspace command-line tool to nixpkgs. This is my first contribution for a project written in python therefore I'm not really sure if this is packaged 'the right way'.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@penguwin penguwin force-pushed the penguwin:nextinspace branch from 0eaccaa to c875306 Oct 20, 2020
Usee python3Packages directly to avoid the overwrite in callPackage

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@penguwin penguwin force-pushed the penguwin:nextinspace branch from c875306 to 78ed7bc Oct 20, 2020
@penguwin
Copy link
Member Author

@penguwin penguwin commented Oct 21, 2020

@SuperSandro2000 thanks for the suggestions! I guess this can be reviewed again (I'm unable to re-request a review via the button)

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 22, 2020

@SuperSandro2000 thanks for the suggestions! I guess this can be reviewed again (I'm unable to re-request a review via the button)

You can't because I am not part of the github org.

Edit: did a quick smoke test and seems to work on macOS.

@penguwin
Copy link
Member Author

@penguwin penguwin commented Oct 26, 2020

Closing as v.1.0.3 released.

@penguwin penguwin closed this Oct 26, 2020
@penguwin penguwin deleted the penguwin:nextinspace branch Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants