Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildGoModule: use optionalString #101104

Merged
merged 1 commit into from Oct 27, 2020
Merged

buildGoModule: use optionalString #101104

merged 1 commit into from Oct 27, 2020

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Oct 19, 2020

Motivation for this change

More consistent with buildGoPackage and it's a bit easier to work with.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Mic92
Mic92 approved these changes Oct 20, 2020
@zowoq zowoq merged commit 092aa94 into NixOS:master Oct 27, 2020
16 checks passed
@zowoq zowoq deleted the gomod-bash-nix branch Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants