Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws sam cli bounds #101107

Merged
merged 3 commits into from Oct 20, 2020
Merged

Aws sam cli bounds #101107

merged 3 commits into from Oct 20, 2020

Conversation

@endgame
Copy link
Contributor

@endgame endgame commented Oct 19, 2020

Motivation for this change

aws-sam-cli fails to build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@jonringer jonringer left a comment

since these are python packages, do you mind prefixing the commits with python3Packages so that the attr path matches?

EDIT:
for example:

python3Packages.aws-sam-cli: <msg>

@endgame endgame force-pushed the aws-sam-cli-bounds branch from 2d48d82 to e052fe5 Oct 20, 2020
@endgame
Copy link
Contributor Author

@endgame endgame commented Oct 20, 2020

Done.

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/101107
9 packages marked as broken and skipped:
mlflow-server python27Packages.trackpy python37Packages.mlflow python37Packages.qasm2image python37Packages.rl-coach python37Packages.trackpy python38Packages.mlflow python38Packages.qasm2image python38Packages.trackpy

11 packages failed to build:
python37Packages.arviz python37Packages.google_cloud_bigquery python37Packages.imbalanced-learn python37Packages.optuna python37Packages.pymc3 python37Packages.rpy2 python37Packages.tensorboardx python38Packages.google_cloud_bigquery python38Packages.imbalanced-learn python38Packages.rpy2 python38Packages.tensorboardx

266 packages built:
apache-airflow aws-sam-cli buildbot buildbot-full buildbot-ui cq-editor csvs-to-sqlite cura gns3-gui gns3-server octoprint python27Packages.aws-lambda-builders python27Packages.aws-sam-translator python27Packages.bkcharts python27Packages.cfn-lint python27Packages.drms python27Packages.duckdb python27Packages.flammkuchen python27Packages.imbalanced-learn python27Packages.mapsplotlib python27Packages.moto python27Packages.pandas python27Packages.seaborn python27Packages.vega_datasets python27Packages.vidstab python27Packages.yfinance python37Packages.Quandl python37Packages.acoustics python37Packages.alerta-server python37Packages.altair python37Packages.aplpy python37Packages.apptools python37Packages.atomman python37Packages.awkward python37Packages.aws-lambda-builders python37Packages.aws-sam-translator python37Packages.batchgenerators python37Packages.bkcharts python37Packages.buildbot python37Packages.buildbot-full python37Packages.buildbot-ui python37Packages.caffe python37Packages.celery python37Packages.cfn-lint python37Packages.cirq python37Packages.clifford python37Packages.cnvkit python37Packages.colorcet python37Packages.csvs-to-sqlite python37Packages.cufflinks python37Packages.dask python37Packages.dask-gateway python37Packages.dask-glm python37Packages.dask-image python37Packages.dask-jobqueue python37Packages.dask-ml python37Packages.dask-mpi python37Packages.dask-xgboost python37Packages.datasets python37Packages.datashader python37Packages.dftfit python37Packages.distributed python37Packages.django-raster python37Packages.djmail python37Packages.drms python37Packages.duckdb python37Packages.envisage python37Packages.fastparquet python37Packages.flammkuchen python37Packages.flower python37Packages.geopandas python37Packages.glymur python37Packages.google_cloud_automl python37Packages.google_cloud_monitoring python37Packages.graspy python37Packages.heudiconv python37Packages.holoviews python37Packages.hvplot python37Packages.ibis-framework python37Packages.image-match python37Packages.imagecorruptions python37Packages.imgaug python37Packages.intake python37Packages.ipydatawidgets python37Packages.lammps-cython python37Packages.mask-rcnn python37Packages.mayavi python37Packages.mesa python37Packages.moto python37Packages.nbsmoke python37Packages.nilearn python37Packages.nipype python37Packages.osmnx python37Packages.osmpythontools python37Packages.pandas python37Packages.partd python37Packages.phik python37Packages.pims python37Packages.pvlib python37Packages.pyarrow python37Packages.pybids python37Packages.pyfftw python37Packages.pymatgen python37Packages.pymatgen-lammps python37Packages.pytrends python37Packages.pywick python37Packages.qiskit python37Packages.qiskit-aer python37Packages.qiskit-aqua python37Packages.qiskit-ibmq-provider python37Packages.qiskit-ignis python37Packages.qiskit-terra python37Packages.runway-python python37Packages.scikit-bio python37Packages.scikitimage python37Packages.seaborn python37Packages.sentry-sdk python37Packages.skorch python37Packages.sparse python37Packages.spectral-cube python37Packages.spyder-kernels_0_5 python37Packages.spyder_3 python37Packages.statsmodels python37Packages.streamz python37Packages.stumpy python37Packages.stytra python37Packages.sumo python37Packages.sunpy python37Packages.tablib python37Packages.tensorly python37Packages.test-tube python37Packages.tiledb python37Packages.traittypes python37Packages.uproot python37Packages.uproot-methods python37Packages.vega python37Packages.vega_datasets python37Packages.vidstab python37Packages.wrf-python python37Packages.xarray python37Packages.xgboost python37Packages.yfinance python38Packages.Quandl python38Packages.acoustics python38Packages.alerta-server python38Packages.altair python38Packages.aplpy python38Packages.apptools python38Packages.atomman python38Packages.awkward python38Packages.aws-lambda-builders python38Packages.aws-sam-translator python38Packages.batchgenerators python38Packages.bkcharts python38Packages.caffe python38Packages.celery python38Packages.cfn-lint python38Packages.cirq python38Packages.clifford python38Packages.cnvkit python38Packages.colorcet python38Packages.cufflinks python38Packages.dask python38Packages.dask-gateway python38Packages.dask-glm python38Packages.dask-image python38Packages.dask-jobqueue python38Packages.dask-ml python38Packages.dask-mpi python38Packages.dask-xgboost python38Packages.datasets python38Packages.datashader python38Packages.dftfit python38Packages.distributed python38Packages.django-raster python38Packages.djmail python38Packages.drms python38Packages.duckdb python38Packages.envisage python38Packages.fastparquet python38Packages.flammkuchen python38Packages.flower python38Packages.geopandas python38Packages.glymur python38Packages.google_cloud_automl python38Packages.google_cloud_monitoring python38Packages.graspy python38Packages.holoviews python38Packages.hvplot python38Packages.image-match python38Packages.imagecorruptions python38Packages.imgaug python38Packages.intake python38Packages.ipydatawidgets python38Packages.lammps-cython python38Packages.mask-rcnn python38Packages.mayavi python38Packages.mesa python38Packages.moto python38Packages.nbsmoke python38Packages.nilearn python38Packages.nipype python38Packages.osmnx python38Packages.osmpythontools python38Packages.pandas python38Packages.partd python38Packages.phik python38Packages.pims python38Packages.pvlib python38Packages.pyarrow python38Packages.pybids python38Packages.pyfftw python38Packages.pymatgen python38Packages.pymatgen-lammps python38Packages.pytrends python38Packages.pywick python38Packages.qiskit python38Packages.qiskit-aer python38Packages.qiskit-aqua python38Packages.qiskit-ibmq-provider python38Packages.qiskit-ignis python38Packages.qiskit-terra python38Packages.runway-python python38Packages.scikit-bio python38Packages.scikitimage python38Packages.seaborn python38Packages.sentry-sdk python38Packages.skorch python38Packages.sparse python38Packages.spectral-cube python38Packages.spyder-kernels_0_5 python38Packages.spyder_3 python38Packages.statsmodels python38Packages.streamz python38Packages.stumpy python38Packages.stytra python38Packages.sumo python38Packages.sunpy python38Packages.tablib python38Packages.tensorly python38Packages.test-tube python38Packages.tiledb python38Packages.traittypes python38Packages.uproot python38Packages.uproot-methods python38Packages.vega python38Packages.vega_datasets python38Packages.vidstab python38Packages.wrf-python python38Packages.xarray python38Packages.xgboost python38Packages.yfinance sourcehut.buildsrht sourcehut.dispatchsrht sourcehut.gitsrht sourcehut.hgsrht sourcehut.hubsrht sourcehut.listssrht sourcehut.mansrht sourcehut.metasrht sourcehut.pastesrht sourcehut.todosrht streamlit tebreak truvari visidata

@jonringer jonringer merged commit bdbcfb4 into NixOS:master Oct 20, 2020
17 checks passed
@endgame
Copy link
Contributor Author

@endgame endgame commented Oct 20, 2020

Thanks @jonringer . Should I do a ZHF PR too? It looks like my last round of SAM CLI fixes landed on 20.09, but the breakage that was on master never came across.

@endgame endgame deleted the aws-sam-cli-bounds branch Oct 20, 2020
@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 20, 2020

I think this was only necessary because of a recent aws bump on master, 20.09 isn't affected #99276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants