Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] sage: 8.9 -> 9.1 #101116

Closed
wants to merge 1 commit into from
Closed

[WIP] sage: 8.9 -> 9.1 #101116

wants to merge 1 commit into from

Conversation

@omasanori
Copy link
Contributor

@omasanori omasanori commented Oct 20, 2020

Motivation for this change

THIS DOES NOT WORK YET

This change updates sage to a newer version. Migrating to Python 3 is out of scope for this moment.

Currently, it fails to build sagelib with the following error:

g++ -pthread -shared -lgcc_s build/temp.linux-x86_64-2.7/build/cythonized/sage/libs/linbox/linbox_flint_interface.o -L/nix/store/a9w45db5c2gyjv3zhdvarm7rw8s6a3jl-linbox-1.6.3/lib -L/nix/store/f48376wgp8cy00sxglmk79dv0ga5xvid-givaro-4.1.1/lib -L/build/sage-src-9.1/lib -L/nix/store/a3zwdl2m606mynzxcqa77ymk6a3j9nnf-python-2.7.18/lib -llinbox -lgivaro -lflint -lgmp -lgmpxx -lcblas -lstdc++ -lpython2.7 -o build/lib.linux-x86_64-2.7/sage/libs/linbox/linbox_flint_interface.so @LINBOXSAGE_LIBS@ -fopenmp
g++: error: LINBOXSAGE_LIBS@: No such file or directory

which indicates that variable substitution is incomplete for some reasons.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Some changes are derived from NixOS#70474
originally published by Timo Kaufmann.

Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
@omasanori
Copy link
Contributor Author

@omasanori omasanori commented Oct 21, 2020

Following the maintainer's suggestion, the current target is to-be-released-soon SageMath 9.2 instead of 9.1. SageMath 9.2 removes sagenb, a component causing many adhoc workarounds in the package, and supports Python 3 only.

@omasanori
Copy link
Contributor Author

@omasanori omasanori commented Oct 22, 2020

Superseded by the to-be-pull-requested https://github.com/omasanori/nixpkgs/tree/sage-9.2 branch.

@omasanori omasanori closed this Oct 22, 2020
@omasanori omasanori deleted the sage-9.1 branch Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant