Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

croc: add passthru.tests #101126

Merged
merged 1 commit into from Oct 25, 2020
Merged

croc: add passthru.tests #101126

merged 1 commit into from Oct 25, 2020

Conversation

@wamserma
Copy link
Contributor

@wamserma wamserma commented Oct 20, 2020

Add simple test to check functionality.

Motivation for this change

#100909 (review)
#101587

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review pr 101126"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@wamserma
Copy link
Contributor Author

@wamserma wamserma commented Oct 20, 2020

ping @HugoReeves @marsam for review

Copy link
Member

@roberth roberth left a comment

Lgtm, but not merging because I'm not a user.
@HugoReeves, @equirosa, @kalbasit any suggestions?

Copy link
Member

@HugoReeves HugoReeves left a comment

Builds and executes on MacOS. LGTM

@equirosa
Copy link
Contributor

@equirosa equirosa commented Oct 21, 2020

LGTM too 👍

@FRidh FRidh merged commit 166a064 into NixOS:master Oct 25, 2020
18 checks passed
@wamserma wamserma deleted the croc-add-test branch Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants