Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vkquake: fix the build #101173

Merged
merged 1 commit into from Oct 20, 2020
Merged

vkquake: fix the build #101173

merged 1 commit into from Oct 20, 2020

Conversation

@peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Oct 20, 2020

Motivation for this change

Apply a patch currently in master to make things build again.

Minor cleanups as a consequence of nixpkgs-fmt running as part of the save.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@peterhoeg
Copy link
Member Author

@peterhoeg peterhoeg commented Oct 20, 2020

Cc: @gnidorah

@peterhoeg peterhoeg merged commit b65f1a4 into NixOS:master Oct 20, 2020
19 checks passed
@ghost
Copy link

@ghost ghost commented Oct 20, 2020

@peterhoeg Thanks! I see a lot of my packages are failing to build since last nixos-unstable update

@peterhoeg peterhoeg deleted the f/vkquake branch Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant