Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgs/top-level/aliases.nix: improve error messages #101174

Merged
merged 1 commit into from Oct 22, 2020

Conversation

@xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Oct 20, 2020

Change error messages in aliases.nix to start with or at least mention the name of the
package being referenced. This avoids obscure error messages like
"error: Abandoned by upstream." when rebuilding your system.
Also do some trivial cosmetic changes while touching things.

Motivation for this change

See #101098 for an example of the issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/top-level/aliases.nix Outdated Show resolved Hide resolved
Change error messages to start with or at least mention the name of the
package being referenced. This avoids obscure error messages like
"error: Abandoned by upstream." when rebuilding your system.
Also do some trivial cosmetic changes while touching things.
@xaverdh xaverdh force-pushed the aliases-throws-names branch from a74f08e to 9c3bc4a Oct 22, 2020
@xaverdh
Copy link
Contributor Author

@xaverdh xaverdh commented Oct 22, 2020

(rebased)

@jtojnar jtojnar merged commit 4147603 into NixOS:master Oct 22, 2020
16 checks passed
@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 22, 2020

Nice, thank you.

@xaverdh xaverdh deleted the aliases-throws-names branch Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants