Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.tensorflow: break if gast not correct #101188

Merged
merged 1 commit into from Oct 31, 2020

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 20, 2020

Motivation for this change

this just fails a lot in reviews, and takes forever to build.

Just fail the evaluation if it's going to fail to install the wheel

did gast != "0.3.2" so that people using overlays aren't broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer jonringer requested a review from FRidh as a code owner Oct 20, 2020
@jonringer jonringer merged commit b8f45c3 into NixOS:master Oct 31, 2020
16 checks passed
@jonringer jonringer deleted the tensorflow-broken branch Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant