Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yamale: init at 3.0.4 #101208

Merged
merged 2 commits into from Oct 21, 2020
Merged

yamale: init at 3.0.4 #101208

merged 2 commits into from Oct 21, 2020

Conversation

@rtburns-jpl
Copy link
Contributor

@rtburns-jpl rtburns-jpl commented Oct 20, 2020

Adds Yamale, an MIT-licensed schema and validator for YAML developed by 23andMe.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@jonringer jonringer left a comment

second commit should be:

python3Packages.yamale: init at 3.0.4

otherwise LGTM

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 21, 2020

Also, thanks for opening your first PR against Nixpkgs @rtburns-jpl :)

Copy link
Contributor

@jonringer jonringer left a comment

This also looks like it can be used as a cli tool https://github.com/23andMe/Yamale#command-line

please add the following to all-packages.nix

  yamale = with python3Packages; toPythonApplication yamale;

this addition should be amended to the addition commit

Copy link
Contributor

@jonringer jonringer left a comment

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/101208
2 packages built:
python37Packages.yamale yamale

@jonringer jonringer merged commit 40e9a23 into NixOS:master Oct 21, 2020
13 of 16 checks passed
@rtburns-jpl rtburns-jpl deleted the yamale branch Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants