Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/ldap: restart nslcd when configuration changes #101224

Merged
merged 3 commits into from Dec 11, 2020
Merged

Conversation

@aanderse
Copy link
Member

@aanderse aanderse commented Oct 20, 2020

Motivation for this change

I noticed that the restartTriggers in this module were wrong.

Note that this new value for restartTriggers is a best effort - we can't tell if the content of a password file has changed, so we assume the content of a password file is different if the path to the password file has changed. Another option is to only pass the contents of the configuration file to restartTriggers and have the user manually restart the service if the password changes. Or tell the user to utilize something like nix-sops 🤷‍♂️

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
flokli
flokli approved these changes Oct 24, 2020
@aanderse aanderse marked this pull request as ready for review Oct 24, 2020
@aanderse aanderse merged commit 9826371 into NixOS:master Dec 11, 2020
17 checks passed
@aanderse aanderse deleted the ldap branch Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants