Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtapi: fix build for linux #101226

Merged
merged 1 commit into from Oct 29, 2020
Merged

libtapi: fix build for linux #101226

merged 1 commit into from Oct 29, 2020

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 21, 2020

Motivation for this change

noticed when reviewing #101215

/nix/store/ajq5dfwn4hzlx1qf2xxwb6rj8a7s65nm-stdenv-linux/setup: line 81: install_name_tool: command not found
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@thefloweringash
Copy link
Member

@thefloweringash thefloweringash commented Oct 21, 2020

This package should be able to build on linux as well as darwin. Since the failure is in postInstall, it probably did build. Can we make the postInstall step conditional instead?

@jonringer jonringer force-pushed the jonringer:darwin-libtapi branch from ee8f7b4 to 054d29d Oct 21, 2020
@jonringer jonringer changed the title libtapi: mark as darwin only libtapi: fix build for linux Oct 21, 2020
@jonringer jonringer force-pushed the jonringer:darwin-libtapi branch from 054d29d to 763d657 Oct 21, 2020
@jonringer jonringer changed the base branch from master to staging Oct 27, 2020
@jonringer jonringer force-pushed the jonringer:darwin-libtapi branch from 763d657 to 1f60bc5 Oct 27, 2020
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Oct 27, 2020

wow! was able to do do a master -> staging rebase without pinging all the CODEOWNERS 👍

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Oct 27, 2020

This shouldn't have changed anything for darwin. But I guess that's why staging exists.

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Oct 27, 2020

@GrahamcOfBorg build darwin.libtapi

@jonringer jonringer force-pushed the jonringer:darwin-libtapi branch from 1f60bc5 to 6c84426 Oct 27, 2020
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Oct 27, 2020

looks like I forgot the original PR had more than one commit.

@jonringer jonringer merged commit 16357a6 into NixOS:staging Oct 29, 2020
17 checks passed
17 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6c84426"; rev="6c8442667de270922bf6462c8f1339e483b3756c"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6c84426"; rev="6c8442667de270922bf6462c8f1339e483b3756c"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6c84426"; rev="6c8442667de270922bf6462c8f1339e483b3756c"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6c84426"; rev="6c8442667de270922bf6462c8f1339e483b3756c"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6c84426"; rev="6c8442667de270922bf6462c8f1339e483b3756c"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6c84426"; rev="6c8442667de270922bf6462c8f1339e483b3756c"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6c84426"; rev="6c8442667de270922bf6462c8f1339e483b3756c"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants