Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-extensions.dhall.{dhall-lang,vscode-dhall-lsp-server}: init at 0.0.4 #101230

merged 2 commits into from Oct 25, 2020


Copy link

@mcwitt mcwitt commented Oct 21, 2020

Motivation for this change

Adds syntax highlighting and LSP integration for the Dhall configuration language.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
@mcwitt mcwitt requested a review from jonringer as a code owner Oct 21, 2020
@mcwitt mcwitt changed the title vscode-extensions.dhall.dhall-lang: init at 0.0.4 vscode-extensions.dhall.{dhall-lang,vscode-dhall-lsp-server}: init at 0.0.4 Oct 21, 2020
Copy link

@jonringer jonringer left a comment

Please follow and manual#submitting-changes-making-patches and squash the fix-up commits.

commits should be:

vscode-extensions.dhall.dhall-lang: init at 0.0.4
vscode-extensions.dhall.vscode-dhall-lsp-server: init at 0.0.4

Copy link
Contributor Author

@mcwitt mcwitt commented Oct 21, 2020

@jonringer sorry about that, thanks for catching! should be fixed now

@bjornfor bjornfor merged commit cc25408 into NixOS:master Oct 25, 2020
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants