Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdl-dump: init at 2020-07-28 #101243

Closed
wants to merge 1 commit into from
Closed

Conversation

@makefu
Copy link
Contributor

@makefu makefu commented Oct 21, 2020

Motivation for this change

init hdl-dump, which is being used in the tutorial for https://nixos.wiki/wiki/Playstation2

ref: #91714

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
version = "0.9.2.20202807";
pname = "hdl_dump";

# playstation2/hdl-dump is outdated
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 27, 2020

Suggested change
# playstation2/hdl-dump is outdated
# https://github.com/playstation2/hdl-dump is outdated

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

Result of nixpkgs-review pr 101243 run on x86_64-linux 1

1 package built:
  • hdl-dump

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Nov 27, 2020

@makefu ping

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Nov 30, 2020

Closoing due to inactivity. I will upload it later.

version = "0.9.2.20202807";
pname = "hdl_dump";
Copy link
Member

@SuperSandro2000 SuperSandro2000 Dec 1, 2020

Suggested change
version = "0.9.2.20202807";
pname = "hdl_dump";
pname = "hdl_dump";
version = "47";

src = fetchFromGitHub {
owner = "AKuHAK";
repo = "hdl-dump";
rev = "be37e112a44772a1341c867dc3dfee7381ce9e59";
Copy link
Member

@SuperSandro2000 SuperSandro2000 Dec 1, 2020

Suggested change
rev = "be37e112a44772a1341c867dc3dfee7381ce9e59";
rev = version;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants