Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuraft: init at 1.1.2 #101247

Merged
merged 2 commits into from Oct 29, 2020
Merged

nuraft: init at 1.1.2 #101247

merged 2 commits into from Oct 29, 2020

Conversation

@wheelsandmetal
Copy link
Contributor

@wheelsandmetal wheelsandmetal commented Oct 21, 2020

Motivation for this change

Add nuraft lib

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@wheelsandmetal
Copy link
Contributor Author

@wheelsandmetal wheelsandmetal commented Oct 21, 2020

Not sure who to set as maintainer

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Oct 23, 2020

@wheelsandmetal

If you are interested in maintain this package, you can add yourself at maintainers/maintainer-list.nix and add it to meta.maintainers list, or else just keep the list empty (basically "orphaning" the package).

Also, squash your commits to more meaningful messages. We don't pollut the commit log with small messages as "applying suggested changes" or "fix trailing whitespace". Just the original message "nuraft: init at 1.1.2" suffices.

@wheelsandmetal wheelsandmetal force-pushed the wheelsandmetal:add-nuraft-lib branch from 1811bc2 to cfc9a72 Oct 27, 2020
@wheelsandmetal
Copy link
Contributor Author

@wheelsandmetal wheelsandmetal commented Oct 27, 2020

@wheelsandmetal

If you are interested in maintain this package, you can add yourself at maintainers/maintainer-list.nix and add it to meta.maintainers list, or else just keep the list empty (basically "orphaning" the package).

Sure

Also, squash your commits to more meaningful messages. We don't pollut the commit log with small messages as "applying suggested changes" or "fix trailing whitespace". Just the original message "nuraft: init at 1.1.2" suffices.

ah didn't know, thanks!

Copy link
Member

@AndersonTorres AndersonTorres left a comment

@wheelsandmetal

Also, squash your commits to more meaningful messages. We don't pollut the commit log with small messages as "applying suggested changes" or "fix trailing whitespace". Just the original message "nuraft: init at 1.1.2" suffices.

ah didn't know, thanks!

Split the commits:

  • One for "add myself to maintainers"
  • The next one "nuraft: init at 1.1.2"
pkgs/development/libraries/nuraft/default.nix Outdated Show resolved Hide resolved
@wheelsandmetal wheelsandmetal force-pushed the wheelsandmetal:add-nuraft-lib branch from cfc9a72 to 166eade Oct 29, 2020
@wheelsandmetal wheelsandmetal requested a review from AndersonTorres Oct 29, 2020
Copy link
Member

@AndersonTorres AndersonTorres left a comment

LGTM, LGTBorg

@AndersonTorres AndersonTorres merged commit 75b92ef into NixOS:master Oct 29, 2020
19 checks passed
19 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="166eade"; rev="166eadee60ade4793b8209ec1aca3b57e114df94"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="166eade"; rev="166eadee60ade4793b8209ec1aca3b57e114df94"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="166eade"; rev="166eadee60ade4793b8209ec1aca3b57e114df94"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="166eade"; rev="166eadee60ade4793b8209ec1aca3b57e114df94"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="166eade"; rev="166eadee60ade4793b8209ec1aca3b57e114df94"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="166eade"; rev="166eadee60ade4793b8209ec1aca3b57e114df94"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="166eade"; rev="166eadee60ade4793b8209ec1aca3b57e114df94"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg
nuraft, nuraft.passthru.tests on aarch64-linux Success
Details
@ofborg
nuraft, nuraft.passthru.tests on x86_64-linux Success
Details
@wheelsandmetal wheelsandmetal deleted the wheelsandmetal:add-nuraft-lib branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants