Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pfsshell: init at 1.1.1 #101248

Merged
merged 2 commits into from Dec 8, 2020
Merged

pfsshell: init at 1.1.1 #101248

merged 2 commits into from Dec 8, 2020

Conversation

@makefu
Copy link
Contributor

@makefu makefu commented Oct 21, 2020

Motivation for this change

init pfsshell, which is being used in the tutorial for https://nixos.wiki/wiki/Playstation2
#79142

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

Result of nixpkgs-review pr 101248 run on x86_64-linux 1

1 package built:
  • pfsshell

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 27, 2020

Result of nixpkgs-review pr 101248 run on x86_64-darwin 1

1 package built:
  • pfsshell

@makefu makefu force-pushed the pkgs/pfsshell/init branch from 3d28d8e to 2155413 Dec 1, 2020
@makefu makefu requested a review from alyssais as a code owner Dec 1, 2020
@makefu
Copy link
Contributor Author

@makefu makefu commented Dec 1, 2020

@SuperSandro2000 i added afl20 to licenses

pkgs/tools/misc/pfsshell/default.nix Outdated Show resolved Hide resolved
@makefu makefu force-pushed the pkgs/pfsshell/init branch from 2155413 to 41bded7 Dec 4, 2020
@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 8, 2020

Result of nixpkgs-review pr 101248 run on x86_64-linux 1

1 package built:
  • pfsshell

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Dec 8, 2020

Result of nixpkgs-review pr 101248 run on x86_64-darwin 1

1 package built:
  • pfsshell

@SuperSandro2000 SuperSandro2000 merged commit 8c321dd into NixOS:master Dec 8, 2020
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants