Skip to content

/ nixpkgs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt: 6.2.1 -> 7.0.3 #101251

Merged
merged 3 commits into from Nov 13, 2020
Merged

fmt: 6.2.1 -> 7.0.3 #101251

merged 3 commits into from Nov 13, 2020

Conversation

@samuelgrf
Copy link
Member

@samuelgrf samuelgrf commented Oct 21, 2020 •
edited

Motivation for this change

pcsx2 master depends on fmt 7.0.3 and up, it'd be best to update fmt before pcsx2's next release, so we aren't stuck on an older version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot requested a review from jeroendehaas Oct 21, 2020
@samuelgrf

This comment has been hidden.

Sign in to view
@samuelgrf samuelgrf marked this pull request as draft Oct 21, 2020
@samuelgrf samuelgrf force-pushed the samuelgrf:update-fmt branch from 7100531 to 0fa15ad Oct 23, 2020
samuelgrf added 2 commits Oct 21, 2020
@samuelgrf
fmt: 6.2.1 -> 7.0.3
Verified
This commit was signed with a verified signature.
samuelgrf Samuel Gräfenstein
GPG key ID: EF76A063F15C63C8 Learn about signing commits
67f70f9
@samuelgrf
fmt_6, fmt_7: init
Verified
This commit was signed with a verified signature.
samuelgrf Samuel Gräfenstein
GPG key ID: EF76A063F15C63C8 Learn about signing commits
0c10d50
@samuelgrf samuelgrf force-pushed the samuelgrf:update-fmt branch from 0fa15ad to 0ba373b Oct 23, 2020
@samuelgrf
gerbera, waybar: build with fmt_6
Verified
This commit was signed with a verified signature.
samuelgrf Samuel Gräfenstein
GPG key ID: EF76A063F15C63C8 Learn about signing commits
Loading status checks…
e8c80d8
@samuelgrf samuelgrf force-pushed the samuelgrf:update-fmt branch from 0ba373b to e8c80d8 Oct 23, 2020
@samuelgrf
Copy link
Member Author

@samuelgrf samuelgrf commented Oct 23, 2020

Result of nixpkgs-review pr 101251 1

23 packages built:
  • adlplug
  • d-seams
  • fmt
  • fmt_6
  • kodi (xbmc)
  • kodi-gbm
  • kodi-wayland
  • kodiGBM
  • kodiPlain (xbmcPlain)
  • kodiPlainWayland
  • kodiPlugins.inputstream-adaptive
  • kodiPlugins.joystick
  • kodiPlugins.kodi-platform
  • kodiPlugins.pvr-hdhomerun
  • kodiPlugins.pvr-hts
  • kodiPlugins.pvr-iptvsimple
  • kodiPlugins.steam-controller
  • kodiPlugins.vfs-libarchive
  • kodiPlugins.vfs-sftp
  • mkvtoolnix
  • mkvtoolnix-cli
  • mpvScripts.convert
  • opnplug
@samuelgrf samuelgrf marked this pull request as ready for review Oct 23, 2020
@samuelgrf samuelgrf mentioned this pull request Nov 11, 2020
Merged
5 of 10 tasks complete
@samuelgrf
Copy link
Member Author

@samuelgrf samuelgrf commented Nov 13, 2020

@Lassulus can you review this?
@Lassulus
Copy link
Contributor

@Lassulus Lassulus commented Nov 13, 2020

Result of nixpkgs-review pr 101251 1

23 packages built:
  • adlplug
  • d-seams
  • fmt (fmt_7)
  • fmt_6
  • kodi
  • kodi-gbm
  • kodi-wayland
  • kodiGBM
  • kodiPlain (kodiPlugins.kodi)
  • kodiPlainWayland
  • kodiPlugins.inputstream-adaptive
  • kodiPlugins.joystick
  • kodiPlugins.kodi-platform
  • kodiPlugins.pvr-hdhomerun
  • kodiPlugins.pvr-hts
  • kodiPlugins.pvr-iptvsimple
  • kodiPlugins.steam-controller
  • kodiPlugins.vfs-libarchive
  • kodiPlugins.vfs-sftp
  • mkvtoolnix
  • mkvtoolnix-cli
  • mpvScripts.convert
  • opnplug
@Lassulus Lassulus merged commit 5c816b9 into NixOS:master Nov 13, 2020
19 checks passed
19 checks passed
tests
Details
action
Details
fmt, fmt.passthru.tests, fmt_6, fmt_6.passthru.tests, fmt_7, fmt_7.passthru.tests, gerbera, gerbera.passthru.tests, waybar, waybar.passthru.tests on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
fmt, fmt.passthru.tests, fmt_6, fmt_6.passthru.tests, fmt_7, fmt_7.passthru.tests, gerbera, gerbera.passthru.tests, waybar, waybar.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e8c80d8"; rev="e8c80d8a2606989dc43a5f3662fd13ef54e67ad6"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e8c80d8"; rev="e8c80d8a2606989dc43a5f3662fd13ef54e67ad6"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e8c80d8"; rev="e8c80d8a2606989dc43a5f3662fd13ef54e67ad6"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e8c80d8"; rev="e8c80d8a2606989dc43a5f3662fd13ef54e67ad6"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e8c80d8"; rev="e8c80d8a2606989dc43a5f3662fd13ef54e67ad6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e8c80d8"; rev="e8c80d8a2606989dc43a5f3662fd13ef54e67ad6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e8c80d8"; rev="e8c80d8a2606989dc43a5f3662fd13ef54e67ad6"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@colemickens colemickens mentioned this pull request Nov 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeroendehaas jeroendehaas

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 8.has: package (new)
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@samuelgrf @Lassulus