Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.{pygtrie, betacode}: init #101255

Merged
merged 2 commits into from Nov 17, 2020
Merged

Conversation

@kmein
Copy link
Contributor

@kmein kmein commented Oct 21, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Lassulus
Copy link
Member

@Lassulus Lassulus commented Oct 24, 2020

getting this error for betacode on python2:

builder for '/nix/store/7cc9snhy0kjsskb77mb23fm2z8f03rr9-python2.7-betacode-1.0.drv' failed with exit code 1; last 10 log lines:
  Executing setuptoolsBuildPhase
  Traceback (most recent call last):
    File "nix_run_setup", line 8, in <module>
      exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
    File "setup.py", line 22, in <module>
      long_description = read('README.rst'),
    File "setup.py", line 14, in read
      with open(os.path.join(os.path.dirname(__file__), fn), encoding='utf-8') as f:
  TypeError: 'encoding' is an invalid keyword argument for this function
  builder for '/nix/store/7cc9snhy0kjsskb77mb23fm2z8f03rr9-python2.7-betacode-1.0.drv' failed with exit code 1
cannot build derivation '/nix/store/shllrgfahfx5di0vpkigkq0s5znwncp5-env.drv': 1 dependencies couldn't be built

maybe disable it on python2?

@kmein kmein force-pushed the feature/python-packages branch from b5bf1f0 to 7fb406c Oct 24, 2020
@kmein
Copy link
Contributor Author

@kmein kmein commented Oct 24, 2020

maybe disable it on python2?

done ✔️

@kmein kmein force-pushed the feature/python-packages branch from 7fb406c to d65c069 Oct 24, 2020
@kmein kmein force-pushed the feature/python-packages branch from d65c069 to cd63b94 Oct 24, 2020
@kmein kmein requested a review from Lassulus Oct 25, 2020
@Lassulus Lassulus merged commit 0749c7d into NixOS:master Nov 17, 2020
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants