Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.ferm: fix network timeout #101258

Merged
merged 1 commit into from Oct 24, 2020
Merged

nixosTests.ferm: fix network timeout #101258

merged 1 commit into from Oct 24, 2020

Conversation

@B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Oct 21, 2020

Motivation for this change

The subtests could start before the server has configured it's IP addresses and therefore randomly timeout.

Example failing Hydra build:

Example Hydra jobs with regular failures:

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
The subtests could start before the server has configured it's IP
addresses and therefore timeout.
@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 24, 2020

@GrahamcOfBorg test ferm

@jonringer jonringer merged commit 2539542 into NixOS:master Oct 24, 2020
18 checks passed
@B4dM4n B4dM4n deleted the ferm-test-fix branch Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants