Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssm-session-manager-plugin: add support for x86_64-darwin #101262

Closed
wants to merge 1 commit into from

Conversation

@nbr
Copy link
Contributor

@nbr nbr commented Oct 21, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot requested a review from martinbaillie Oct 21, 2020
@nbr nbr force-pushed the nb-session-mgr-darwin branch from 6cc0716 to 3315c94 Oct 21, 2020
@nbr nbr changed the title add darwin support to ssm-session-manager-plugin ssm-session-manager-plugin: add support for x86_64-darwin Oct 21, 2020
@nbr nbr marked this pull request as ready for review Oct 21, 2020
@nbr nbr force-pushed the nb-session-mgr-darwin branch from 7a53f98 to f4ed4a3 Nov 30, 2020
@nbr nbr requested a review from SuperSandro2000 Nov 30, 2020
@nbr
Copy link
Contributor Author

@nbr nbr commented Nov 30, 2020

Closing in favor of #102103

@nbr nbr closed this Nov 30, 2020
@nbr nbr deleted the nb-session-mgr-darwin branch Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants