Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.ftputil: fix tests on darwin #101263

Merged
merged 1 commit into from Oct 23, 2020

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Oct 21, 2020

Motivation for this change

https://hydra.nixos.org/build/128502414

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@SuperSandro2000 SuperSandro2000 changed the title python3Packages: fix tests on darwin python3Packages.ftputil: fix tests on darwin Oct 21, 2020
@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 23, 2020

Huh, how is this disabling a test a fix?

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Oct 23, 2020

As far as I understand the error output is slightly different on darwin which causes the test to fail:

self = <test.test_error.TestErrorConversion object at 0x110663910>

    def test_error_message_reuse(self):
        """
        Test if the error message string is retained if the caught exception
        has more than one element in `args`.
        """
        # See ticket #76.
        with pytest.raises(ftputil.error.FTPOSError) as exc_info:
            # Format "host:port" doesn't work. The use here is intentional.
            host = ftputil.FTPHost("localhost:21", "", "")
        exc = exc_info.value
        # The error message may be different for different Python versions.
>       assert "No address associated with hostname" in str(
            exc
        ) or "Name or service not known" in str(exc)
E       AssertionError: assert ('No address associated with hostname' in '[Errno 8] nodename nor servname provided, or not known\nDebugging info: ftputil 4.0.0, Python 3.8.6 (darwin)' or 'Name or service not known' in '[Errno 8] nodename nor servname provided, or not known\nDebugging info: ftputil 4.0.0, Python 3.8.6 (darwin)')
E        +  where '[Errno 8] nodename nor servname provided, or not known\nDebugging info: ftputil 4.0.0, Python 3.8.6 (darwin)' = str(FTPOSError(8, 'nodename nor servname provided, or not known'))
E        +  and   '[Errno 8] nodename nor servname provided, or not known\nDebugging info: ftputil 4.0.0, Python 3.8.6 (darwin)' = str(FTPOSError(8, 'nodename nor servname provided, or not known'))

test/test_error.py:66: AssertionError

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 23, 2020

They're already testing two other variants. Please ask upstream if they can add

nodename nor servname provided, or not known

to this test and disable this test conditionally dependent on stdenv.isDarwin with a comment referencing the upstream issue.

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 commented Oct 23, 2020

They're already testing two other variants. Please ask upstream if they can add

After searching for a bit through trac I created https://ftputil.sschwarzer.net/trac/ticket/140#ticket.

@SuperSandro2000 SuperSandro2000 force-pushed the ftputil-mac branch 2 times, most recently from b9311df to 2099e3d Oct 23, 2020
@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 23, 2020

Result of nixpkgs-review pr 101263 1

2 packages built:
  • python37Packages.ftputil
  • python38Packages.ftputil

@mweinelt mweinelt merged commit cf068be into NixOS:master Oct 23, 2020
17 checks passed
17 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions[bot]
Wait for ofborg
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d42f23d"; rev="d42f23d4ced57d3377ab9cf91a6d12ff896f27b3"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d42f23d"; rev="d42f23d4ced57d3377ab9cf91a6d12ff896f27b3"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d42f23d"; rev="d42f23d4ced57d3377ab9cf91a6d12ff896f27b3"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d42f23d"; rev="d42f23d4ced57d3377ab9cf91a6d12ff896f27b3"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d42f23d"; rev="d42f23d4ced57d3377ab9cf91a6d12ff896f27b3"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d42f23d"; rev="d42f23d4ced57d3377ab9cf91a6d12ff896f27b3"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d42f23d"; rev="d42f23d4ced57d3377ab9cf91a6d12ff896f27b3"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@SuperSandro2000 SuperSandro2000 deleted the ftputil-mac branch Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants