Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kdeconnect #101272

Merged
merged 2 commits into from Oct 22, 2020
Merged

Fix kdeconnect #101272

merged 2 commits into from Oct 22, 2020

Conversation

@edolstra
Copy link
Member

@edolstra edolstra commented Oct 21, 2020

Motivation for this change

Fixes #99951. Also bumps kdeconnect to 20.08.2 to fix an incorrect MIME type.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
edolstra added 2 commits Oct 21, 2020
Fixes #99951.

  $ kdeconnect-app
  Cannot mix incompatible Qt library (5.12.7) with this library (5.15.0)
  Aborted (core dumped)
Fixes an invalid MIME type.
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 21, 2020

Makes sense to me, but I'd be surprised if it'd help, considering #100707. Maybe use libsForQt514.callPackage until #100707 is fixed?

@edolstra
Copy link
Member Author

@edolstra edolstra commented Oct 21, 2020

It fixes kdeconnect for me. I don't know if it's the best fix though.

I just tried libsForQt514. It doesn't work either:

$ ./result/bin/kdeconnect-app 
Cannot mix incompatible Qt library (version 0x50c07) with this library (version 0x50e02)
Aborted (core dumped)

@edolstra edolstra merged commit 357a62d into NixOS:master Oct 22, 2020
19 of 20 checks passed
19 of 20 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
kdeconnect, kdeconnect.passthru.tests on x86_64-darwin
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="42bf618"; rev="42bf61811b1e78d4bba2c644c38c50e756234ce3"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="42bf618"; rev="42bf61811b1e78d4bba2c644c38c50e756234ce3"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="42bf618"; rev="42bf61811b1e78d4bba2c644c38c50e756234ce3"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="42bf618"; rev="42bf61811b1e78d4bba2c644c38c50e756234ce3"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="42bf618"; rev="42bf61811b1e78d4bba2c644c38c50e756234ce3"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="42bf618"; rev="42bf61811b1e78d4bba2c644c38c50e756234ce3"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="42bf618"; rev="42bf61811b1e78d4bba2c644c38c50e756234ce3"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg
kdeconnect, kdeconnect.passthru.tests on aarch64-linux Success
Details
@ofborg
kdeconnect, kdeconnect.passthru.tests on x86_64-linux Success
Details
@edolstra edolstra deleted the edolstra:fix-kdeconnect branch Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants