Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.scrapy-fake-useragent: fix license #101278

Merged
merged 1 commit into from Oct 21, 2020

Conversation

@das-g
Copy link
Member

@das-g das-g commented Oct 21, 2020

change meta.license to licenses.mit

Motivation for this change

Upstream changed to MIT with alecxe/scrapy-fake-useragent@0ea7614 (so with Version 1.4.0, it seems), but looks like it got overlooked in b5d6f77, which entered master as part of PR #95609.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
    • meta.description is capitalized
    • meta.description doesn't start with the package name
    • meta.description doesn't have a period at the end
    • meta.license is set and fits the upstream license
    • meta.maintainers is set
@das-g
Copy link
Member Author

@das-g das-g commented Oct 21, 2020

Result of nixpkgs-review pr 101278 1

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 101278 1

@jonringer jonringer merged commit 44465f6 into NixOS:master Oct 21, 2020
2 of 4 checks passed
2 of 4 checks passed
@github-actions[bot]
tests
Details
@github-actions[bot]
action
Details
@github-actions[bot]
Wait for ofborg This failed status will be cleared when ofborg finishes eval.
Details
@ofborg[bot]
grahamcofborg-eval Checking original out paths
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants