Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redshift-plasma-applet: update patchPhase to fix manual updates, don't use upstream #101279

Closed
wants to merge 2 commits into from

Conversation

@aquarial
Copy link

@aquarial aquarial commented Oct 21, 2020

Need to patch every redshift to ${redshift }/bin/redshift so
Nix can use the right binary. Current patch misses one.

Upstream applied https://invent.kde.org/plasma/plasma-redshift-control/-/commit/898c3a4cfc6c317915f1e664078d8606497c4049 to add -P to onetime color settings on redshift version >= 1.12

Since nixpkgs uses 1.12, and upstream seems to break manually toggling the applet off, I applied this fix inline in the patches, and took note of it.

I tested this with a local override, and it works on NixOS+KDE

Motivation for this change

Issue #83250 has been a large blocker from me using NixOS more. I finally dove into fix it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
aquarial added 2 commits Oct 21, 2020
Need to patch every 'redshift' to ${redshift }/bin/redshift so
Nix can use the right binary

 -P     Reset existing gamma ramps before applying new color effect.

Add '-P' flag to redshiftOneTimeCommand because it doesn't
work on NixOS if it's not there (?). I'm not sure how it works
on Ubuntu like it is.

I tested this with a local override, and it works on kde.
@aquarial
Copy link
Author

@aquarial aquarial commented Oct 23, 2020

Found a better way to do this, closing this.

@aquarial aquarial closed this Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant