Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dolphinEmuMaster: 5.0-11824 -> 5.0-12716 #101286

Merged
merged 1 commit into from Oct 22, 2020
Merged

Conversation

@xfix
Copy link
Contributor

@xfix xfix commented Oct 21, 2020

This uses a newest beta release as I think NixOS should be following beta releases (they are rather stable points that work as they are used for Progress Report articles and release way more often than stables).

Motivation for this change

Making .rvz files work. The current version of dolphinEmuMaster is not recent enough.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@ashkitten ashkitten left a comment

lgtm. i've been forgetting to update the package, but yes we want to follow beta releases.

@xfix
Copy link
Contributor Author

@xfix xfix commented Oct 22, 2020

/marvin opt-in
/status needs_merger

@marvin-mk2 marvin-mk2 bot added the marvin label Oct 22, 2020
@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Oct 22, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Oct 22, 2020

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 22, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/251

@Lassulus Lassulus merged commit 404182e into NixOS:master Oct 22, 2020
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants