Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jabref: 3.8.1 -> 5.1 #101287

Merged
merged 1 commit into from Nov 19, 2020
Merged

jabref: 3.8.1 -> 5.1 #101287

merged 1 commit into from Nov 19, 2020

Conversation

@wamserma
Copy link
Contributor

@wamserma wamserma commented Oct 21, 2020

This still feels a bit hacky, so feel free to give it a try with gradle2nix and an openjdk-14 sans openjfx. Meanwhile, this is a step forward to get this overdue version bump.

Motivation for this change

Closes #86331
Closes #90850
Closes https://github.com/NixOS/nixpkgs/pull/72423/files

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@wamserma
Copy link
Contributor Author

@wamserma wamserma commented Oct 26, 2020

@luxferresum can you try/review?
@ckauhaus can you also put the securiy tag here?

@wamserma
Copy link
Contributor Author

@wamserma wamserma commented Nov 2, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Nov 2, 2020
@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Nov 2, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@kevincox kevincox merged commit c46d66d into NixOS:master Nov 19, 2020
19 checks passed
@kevincox
Copy link
Contributor

@kevincox kevincox commented Nov 19, 2020

BTW you should consider adding yourself as a maintainer 😉. You can just send that PR directly to me.

@wamserma wamserma deleted the jabref-5.1 branch Nov 19, 2020
@Coda-Coda
Copy link

@Coda-Coda Coda-Coda commented Feb 5, 2021

@wamserma Hi, thanks for the awesome contribution of bringing JabRef up to 5.1! I just thought I'd mention that I've found that if I use this then opening external files (e.g. attaching a PDF to an entry an opening it, or opening any clickable URL in JabRef) does not work (I'm on NixOS 20.09). With errors such as java.io.IOException: Cannot run program "xdg-open": error=2, No such file or directory. I have found a workaround which is to use @tyrion's approach (using the .deb) mentioned here #86331 (comment) - changing it to 5.1 (and the hash of course) works fine. I'm not sure how easy/hard fixing that issue with 5.1 in nixpkgs would be but just thought I'd mention it. I'm happily using @tyrion's approach for now 🙂

@wamserma
Copy link
Contributor Author

@wamserma wamserma commented Feb 5, 2021

@Coda-Coda Thanks for reporting. I can reproduce this, when running from a pure nix-shell. The reason seems xdg-utils is missing from the runtime deps. I'll pick this up and bump to 5.2.

@alexeymuranov
Copy link
Contributor

@alexeymuranov alexeymuranov commented Apr 6, 2021

Could it be backported to NixOS 20.09?

@wamserma
Copy link
Contributor Author

@wamserma wamserma commented Apr 6, 2021

@alexeymuranov No, as this is not perfectly working (see discussion above and in #112028). It will be in 21.05, though.

@Coda-Coda Coda-Coda mentioned this pull request Jul 20, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment