Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.sqlalchemy: 1.3.19 -> 1.3.20 #101295

Closed
wants to merge 1 commit into from

Conversation

@nbke
Copy link
Contributor

@nbke nbke commented Oct 21, 2020

Motivation for this change

https://docs.sqlalchemy.org/en/13/changelog/changelog_13.html#change-1.3.20

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@r-burns r-burns left a comment

Looks like this should go into staging due to the number of rebuilds

@jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 22, 2020

if it was under 500, I would be fine with master as well. But yea, better just target staging

git rebase --onto=origin/staging HEAD^
git push ... ... --force

then you need to edit the target branch on this PR

@FRidh
Copy link
Member

@FRidh FRidh commented Oct 25, 2020

Included in #101636.

@FRidh FRidh closed this Oct 25, 2020
@nbke nbke deleted the update-sqlalchemy branch Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants