Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mediatomb: Allow users to customize duktape/js script imports #101296

Closed
wants to merge 1 commit into from

Conversation

@ardumont
Copy link
Contributor

@ardumont ardumont commented Oct 21, 2020

Motivation

With no customization, the default behavior is kept (virtual-layout using the
builtin engine with the default import.js provided by gerbera).

This allows user to develop and provide their own list of customized
duktape/javascript scripts [1]

[1] http://docs.gerbera.io/en/latest/scripting.html

Actions

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS: odroid [2]
    • macOS
    • other Linux distributions: debian with nix
  • Tested via one or more NixOS test(s) [3]
  • nixpkgs-review wip [4]
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

[2] https://gitlab.com/ardumont/nixos/-/blob/master/odroid/mediatomb/default.nix#L24

[3]

$ cd nixos/tests
$ nix-build mediatomb.nix
...
(0.60 seconds)
(13.88 seconds)
test script finished in 13.88s
cleaning up
(0.00 seconds)
/nix/store/pd3wqv8pxjn2fd6r0fv592cz20a5x38x-vm-test-run-mediatomb

[4]

$ nixpkgs-review wip
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 29, done.
remote: Counting objects: 100% (29/29), done.
remote: Total 49 (delta 29), reused 29 (delta 29), pack-reused 20
Unpacking objects: 100% (49/49), 48.46 KiB | 431.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   7c4305be84a..02daf3f0768  master     -> refs/nixpkgs-review/0
$ git worktree add /home/tony/.cache/nixpkgs-review/rev-7c389b0c3ff80affc676793e0f17c8f7dfb1a670-dirty/nixpkgs 02daf3f07688e89d41bbcafca3788edf648a6b31
Preparing worktree (detached HEAD 02daf3f0768)
Updating files: 100% (22980/22980), done.
HEAD is now at 02daf3f0768 Merge pull request #101284 from r-ryantm/auto-update/bdf2psf
$ nix-env -f /home/tony/.cache/nixpkgs-review/rev-7c389b0c3ff80affc676793e0f17c8f7dfb1a670-dirty/nixpkgs -qaP --xml --out-path --show-trace
No diff detected, stopping review...
$ git worktree prune

nixpkgs-review pr 101296
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/101296/head:refs/nixpkgs-review/1
From https://github.com/NixOS/nixpkgs
   37d6d5a32c8..7c389b0c3ff  refs/pull/101296/head -> refs/nixpkgs-review/1
$ git worktree add /home/tony/.cache/nixpkgs-review/pr-101296/nixpkgs 02daf3f07688e89d41bbcafca3788edf648a6b31
Preparing worktree (detached HEAD 02daf3f0768)
Updating files: 100% (22980/22980), done.
HEAD is now at 02daf3f0768 Merge pull request #101284 from r-ryantm/auto-update/bdf2psf
$ nix-env -f /home/tony/.cache/nixpkgs-review/pr-101296/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 7c389b0c3ff80affc676793e0f17c8f7dfb1a670
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/tony/.cache/nixpkgs-review/pr-101296/nixpkgs -qaP --xml --out-path --show-trace --meta
Nothing to be built.
https://github.com/NixOS/nixpkgs/pull/101296
$ nix-shell /home/tony/.cache/nixpkgs-review/pr-101296/shell.nix

[nix-shell:~/.cache/nixpkgs-review/pr-101296]$ exit
$ git worktree prune
With no customization, the default behavior is kept (virtual-layout using the
builtin engine with the default import.js provided by gerbera).

This allows user to develop and provide their own list of customized
duktape/javascript scripts [1]

[1] http://docs.gerbera.io/en/latest/scripting.html
@ardumont
Copy link
Contributor Author

@ardumont ardumont commented Nov 1, 2020

I messed up my source branch which somehow we cannot change...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant