Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox: place alsaLib in lib search patch #101314

Merged
merged 1 commit into from Oct 30, 2020
Merged

Conversation

@S-NA
Copy link
Contributor

@S-NA S-NA commented Oct 22, 2020

Motivation for this change

libcubeb has dlopened libraries for awhile now. In nixpkgs there was
support for the PulseAudio backend doing this, however the ALSA backend
support was missed and caused issue #79310 (no sound with ALSA). This
gives ALSA users the ability to hear sound once again.

libcubeb has dlopened libraries for awhile now. In nixpkgs there was
support for the PulseAudio backend doing this, however the ALSA backend
support was missed and caused issue NixOS#79310 (no sound with ALSA). This
gives ALSA users the ability to hear sound once again.
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Finally! Someone figured it out. Thank you!
I tested that:

  • Firefox builds
  • Audio via ALSA works
  • nixosTests.firefox passes

@ajs124 ajs124 requested a review from andir Oct 22, 2020
andir
andir approved these changes Oct 22, 2020
Copy link
Member

@andir andir left a comment

Nice! Thank you for fixing this issue! This looks reasonable.

I wonder if there is a way we could automate the sound testing in a VM test?

I usually run them for each and every bump of the packages and thus that would allow us to catch it early.

@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 28, 2020

It should be doable: I could create an audio loopback and record that to a WAV file.
Checking if audio is working should be simple as checking if the file is nonempty.

@bhipple bhipple merged commit 57ea265 into NixOS:master Oct 30, 2020
17 checks passed
@rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 31, 2020

Backported to

@S-NA S-NA deleted the wip/firefox-alsa branch Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants