Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl8822ce: init at v5.9.0.3b #101317

Closed
wants to merge 1 commit into from
Closed

rtl8822ce: init at v5.9.0.3b #101317

wants to merge 1 commit into from

Conversation

@pickfire
Copy link
Contributor

@pickfire pickfire commented Oct 22, 2020

This is already available on newer kernels like zen.
Note: build fails on newer kernels due to crc32, but either way never kernels should already have this.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This is already available on newer kernels like zen.
@sdier
Copy link
Contributor

@sdier sdier commented Oct 23, 2020

Reviewed points
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on ARCHITECTURE
  • executables tested on ARCHITECTURE
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • phases are respected
  • patches that are remotely available are fetched with fetchpatch
Possible improvements
Comments

I do not have the relevant hardware, and realized anything I'm going to test this on is running a newer kernel. This otherwise looks ok to me.

@sdier
Copy link
Contributor

@sdier sdier commented Oct 23, 2020

Perhaps if there is any way to know which kernel version this stops being compatible with? Is it possible to prevent this in nix from being built with those kernels?

@sdier
Copy link
Contributor

@sdier sdier commented Oct 23, 2020

For instance: is there a way to limit it to the known-buildable kernels?

2 packages marked as broken and skipped:
linuxPackages_hardkernel_4_14.rtl8822ce linuxPackages_hardkernel_latest.rtl8822ce

8 packages failed to build:
linuxPackages_5_8.rtl8822ce linuxPackages_5_9.rtl8822ce linuxPackages_latest-libre.rtl8822ce linuxPackages_latest_hardened.rtl8822ce linuxPackages_latest_xen_dom0.rtl8822ce linuxPackages_latest_xen_dom0_hardened.rtl8822ce linuxPackages_testing_bcachefs.rtl8822ce linuxPackages_zen.rtl8822ce

9 packages built:
linuxPackages-libre.rtl8822ce linuxPackages.rtl8822ce linuxPackages_4_14.rtl8822ce linuxPackages_4_19.rtl8822ce linuxPackages_4_4.rtl8822ce linuxPackages_4_9.rtl8822ce linuxPackages_hardened.rtl8822ce linuxPackages_xen_dom0.rtl8822ce linuxPackages_xen_dom0_hardened.rtl8822ce

@pickfire
Copy link
Contributor Author

@pickfire pickfire commented Oct 26, 2020

I am not quite sure what is known but I know that zen kernel already have it. Maybe we can just limit it to those that already failed in CI?

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Dec 18, 2020

Perhaps if there is any way to know which kernel version this stops being compatible with? Is it possible to prevent this in nix from being built with those kernels?

Definitely it's possible - you just need to assert before mkDerivation that the version is old enough and throw a proper message otherwise. @pickfire please use lib.asserts.assertMsg (https://nixos.org/manual/nixpkgs/stable/#sec-functions-library) and lib.strings.versionOlder

@pickfire
Copy link
Contributor Author

@pickfire pickfire commented Dec 19, 2020

I am not using nixos anymore and for this one just use one of those kernels to fix it. Closing it.

@pickfire pickfire closed this Dec 19, 2020
@@ -6711,6 +6711,12 @@
githubId = 627831;
name = "Hoang Xuan Phu";
};
pickfire = {
Copy link
Member

@SuperSandro2000 SuperSandro2000 Dec 27, 2020

Please put this into a separate commit with the message maintainers: add pickfire.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants