Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lens: init at 3.6.7 #101325

Merged
merged 2 commits into from Dec 11, 2020
Merged

lens: init at 3.6.7 #101325

merged 2 commits into from Dec 11, 2020

Conversation

@dbirks
Copy link
Member

@dbirks dbirks commented Oct 22, 2020

Motivation for this change

Wanted to contribute a package I use several times a week.

And this should close issue #88168.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@dbirks
Copy link
Member Author

@dbirks dbirks commented Oct 22, 2020

Also removed one whitespace character to hopefully fix the Checking EditorConfig error:

pkgs/applications/networking/cluster/lens/default.nix:
	24: Trailing whitespace

@roberth
Copy link
Member

@roberth roberth commented Nov 10, 2020

Nothing happens when I click any of the documentation links on the right pane when adding a cluster, or when I click the items in the help menu (except What's new).
Stderr doesn't show messages about this, but it seems like it can't browser windows (unlike xdg-open https://nixos.org which does work in my environment)

@dbirks
Copy link
Member Author

@dbirks dbirks commented Nov 11, 2020

Thanks for building and trying it out!
I did a fresh rebuild, and removed my ~/.config/Lens directory to make sure I had a clean environment, but unfortunately I can't reproduce those problems with the links not opening. I'm on GNOME 3 for background.

@roberth
Copy link
Member

@roberth roberth commented Nov 11, 2020

I'm also on GNOME 3. My normal user doesn't get any logs but I've tried it on a clean user with firefox in its profile (nix-env -i) and got this when clicking links:

stderr
/nix/store/2jysm3dfsgby5sw5jgj43qjrb5v79ms9-bash-4.4-p23/bin/bash: symbol lookup error: /usr/lib/libc.so.6: undefined symbol: _dl_fatal_printf, version GLIBC_PRIVATE
/usr/bin/xdg-open: line 883: x-www-browser: command not found
/nix/store/2jysm3dfsgby5sw5jgj43qjrb5v79ms9-bash-4.4-p23/bin/bash: symbol lookup error: /usr/lib/libc.so.6: undefined symbol: _dl_fatal_printf, version GLIBC_PRIVATE
/usr/bin/xdg-open: line 883: iceweasel: command not found
/usr/bin/xdg-open: line 883: seamonkey: command not found
/usr/bin/xdg-open: line 883: mozilla: command not found
/usr/bin/xdg-open: line 883: epiphany: command not found
/usr/bin/xdg-open: line 883: konqueror: command not found
/usr/bin/xdg-open: line 883: chromium: command not found
/usr/bin/xdg-open: line 883: chromium-browser: command not found
/usr/bin/xdg-open: line 883: google-chrome: command not found
/usr/bin/xdg-open: line 883: www-browser: command not found
/usr/bin/xdg-open: line 883: links2: command not found
/usr/bin/xdg-open: line 883: elinks: command not found
/usr/bin/xdg-open: line 883: links: command not found
/usr/bin/xdg-open: line 883: lynx: command not found
/usr/bin/xdg-open: line 883: w3m: command not found
xdg-open: no method available for opening 'https://k8slens.dev/licenses/eula.md'

I'm running NixOS 20.09.

@dbirks
Copy link
Member Author

@dbirks dbirks commented Dec 7, 2020

I'm on different system now, but I haven't been able to get the same errors as you yet. 🙁

I do have my configuration.nix in git now if you want to compare.:
https://github.com/dbirks/dotfiles/blob/master/nixos/etc/nixos/configuration.nix

I wonder if something in this section in services is what's making the difference:

    gnome3 = {
      core-os-services.enable = true;
      core-shell.enable = true;
      core-utilities.enable = true;
    };

Copy link
Member

@roberth roberth left a comment

Links are also unreliable in vscode for me, so it's unlikely to be a lens issue and certainly not a reason to block this pr.
LGTM!

@roberth roberth merged commit 2abae84 into NixOS:master Dec 11, 2020
19 checks passed
@dbirks dbirks deleted the add-lens branch Dec 11, 2020
@dbirks
Copy link
Member Author

@dbirks dbirks commented Dec 11, 2020

Thank you! 🏄

@MaryamTavakkoli
Copy link

@MaryamTavakkoli MaryamTavakkoli commented Dec 18, 2020

Does this work only with Gnome? (I have Plasma and couldn't install lens)

@roberth
Copy link
Member

@roberth roberth commented Dec 18, 2020

We've tested with gnome, but it shouldn't be gnome-specific. Could you provide the error log?

@dbirks
Copy link
Member Author

@dbirks dbirks commented Dec 18, 2020

I hit an error that might be the same as yours:

error: undefined variable 'lens' at /home/david/dotfiles/nixos/etc/nixos/configuration.nix:65:5

I think that's because the nixos-unstable channel has been backed up with a build problem since 9 days ago, before this PR was merged: https://status.nixos.org/

Looks like a fix is on its way though.

voobscout
Copy link
Contributor

voobscout commented on e833e5b Feb 5, 2021

there's a v4.0.8 out, @dbirks mind updating it?

dbirks
Copy link
Member

dbirks commented on e833e5b Feb 5, 2021

@voobscout - I'm using 4.0.6 locally, but I keep getting an extension error whenever I open it, so I haven't PR'd it yet.
Thanks for the ping though, I'm glad it's being used. I'll try out 4.0.8 later on today, and see if I can get around my error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants