Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-cbindgen: 0.14.4 -> 0.15.0 #101326

Merged
merged 1 commit into from Oct 22, 2020
Merged

Conversation

@r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Oct 22, 2020

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/rust-cbindgen/versions.

meta.description for rust-cbindgen is: "A project for generating C bindings from Rust code"

meta.homepage for rust-cbindgen is: "https://github.com/eqrion/cbindgen"

meta.changelog for rust-cbindgen is: ""

Updates performed
  • Rust version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
52 total rebuild path(s)

16 package rebuild(s)

16 x86_64-linux rebuild(s)
15 i686-linux rebuild(s)
6 x86_64-darwin rebuild(s)
15 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
adoptopenjdk-icedtea-web
cinnamon.cinnamon-common
cinnamon.cinnamon-gsettings-overrides
cinnamon.cinnamon-screensaver
cinnamon.cjs
firefox-esr-78-unwrapped
firefox-unwrapped
firefoxPackages.firefox
firefoxPackages.firefox-esr-78
rust-cbindgen
slimerjs
spidermonkey_78
thunderbird
thunderbird-68
thunderbird-78
xulrunner
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/3074537pd7skdl3fbmfxbsdb18qblcrq-rust-cbindgen-0.15.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A rust-cbindgen https://github.com/r-ryantm/nixpkgs/archive/37677080bec5cd26668c9e5f36f0e5787c1aebe3.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/3074537pd7skdl3fbmfxbsdb18qblcrq-rust-cbindgen-0.15.0
ls -la /nix/store/3074537pd7skdl3fbmfxbsdb18qblcrq-rust-cbindgen-0.15.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

1 package failed to build:
  • thunderbird
13 packages built:
  • icedtea_web (icedtea8_web)
  • cinnamon.cinnamon-common
  • cinnamon.cinnamon-gsettings-overrides
  • cinnamon.cinnamon-screensaver
  • cinnamon.cjs
  • firefox (firefox-wrapper ,firefoxWrapper)
  • firefox-esr (firefox-esr-wrapper)
  • firefox-esr-78-unwrapped
  • firefox-unwrapped
  • firefox-wayland
  • rust-cbindgen
  • slimerjs
  • spidermonkey (spidermonkey_78)

Maintainer pings

cc @jtojnar @andir for testing.

andir
andir approved these changes Oct 22, 2020
Copy link
Member

@andir andir left a comment

LGTM: I've built Thunderbird successfully (since that failed for the bot)

@andir andir merged commit d82e635 into NixOS:master Oct 22, 2020
19 of 20 checks passed
@r-ryantm r-ryantm deleted the auto-update/rust-cbindgen branch Oct 24, 2020
@vcunat
Copy link
Member

@vcunat vcunat commented Oct 25, 2020

This is most likely the change that now "causes" build failures on Hydra for thunderbird, firefox and firefox-esr. I haven't managed to reproduce it locally, but there have been many failures on Hydra, e.g. https://hydra.nixos.org/build/128742086#tabs-buildsteps

The several logs I've seen all stop somewhere when compiling [libloading 0.5.2] – and then they time out after 2h of silence. (For these cases it's a bit unfortunate that Nix and Hydra can't keep more than one log for any *.drv.)

@andir: perhaps we can revert for now, but overall I'm not sure what to do next (e.g. how to debug it).

@andir
Copy link
Member

@andir andir commented Oct 25, 2020

Interesting. I am pretty sure those build worked for me as well (as stated above). We can give a revert a try but that would be a very odd behavior..

@vcunat
Copy link
Member

@vcunat vcunat commented Oct 25, 2020

My tip is that some property of the machine/builder is triggering this, as it was pretty well reproducible on Hydra but always scheduled on the "hash-named" boxes which are probably very uniform.

@vcunat
Copy link
Member

@vcunat vcunat commented Oct 25, 2020

I guess the best step forward would be to reproduce it on some interactive machine. So far I've done these builds only on one (and successfully), now I'm trying another one.

@vcunat
Copy link
Member

@vcunat vcunat commented Oct 25, 2020

I've tried three machines now (a few times) but I haven't reproduced it.

@vcunat
Copy link
Member

@vcunat vcunat commented Oct 25, 2020

In a few cases we were lucky on Hydra, getting it scheduled to "wendy" machine where it succeeds, e.g. https://hydra.nixos.org/build/128742086#tabs-buildsteps ... but over long term the current rate of failure doesn't seem sustainable.

@andir
Copy link
Member

@andir andir commented Oct 25, 2020

Looking at https://hydra.nixos.org/build/128739018 it only timed out at the the install checks:

checking for references to /build/ in /nix/store/f6jpcqz1rp82bhlnazdavsw4la9ypbfw-firefox-esr-unwrapped-78.4.0esr...
running install tests
Mozilla Firefox 78.4.0esr

According to our expression this looks like what I'd expect. Maybe Nix on those "hash" machines (which are probably all managed the same way) is a newer/different version with some bug?

@vcunat
Copy link
Member

@vcunat vcunat commented Oct 25, 2020

No, you're too late. Further attempt on the same derivation already succeeded (triggered from a different Hydra job), and the log got overwritten as it's by design one per derivation...

@vcunat
Copy link
Member

@vcunat vcunat commented Oct 25, 2020

Luckily I have a few log instances for the very same derivation (logs downloaded from those Hydra.nixos.org links), so for reference here's one: 45aby83kdjlsphifd91zwbns52k87vrq-firefox-esr-unwrapped-78.4.0esr.log

@andir
Copy link
Member

@andir andir commented Oct 25, 2020

Shall we try reverting this PR then? The current state isn't good.

@vcunat
Copy link
Member

@vcunat vcunat commented Oct 25, 2020

I suppose so. But I see it just as a way to buy more time.

@andir
Copy link
Member

@andir andir commented Oct 26, 2020

@vcunat
Copy link
Member

@vcunat vcunat commented Dec 1, 2020

Apparently this update wasn't the issue. For example, all the timeouts here looked the same and it was with 0.14.4. I hope this will improve with big-parallel (PR #105345).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants