Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perldevel: 5.33.2 -> 5.33.3, perl-cross: f59d2b6 -> 65e06e2 #101336

Merged
merged 1 commit into from Oct 23, 2020

Conversation

@stigtsp
Copy link
Member

@stigtsp stigtsp commented Oct 22, 2020

https://metacpan.org/changes/release/SHAY/perl-5.33.3

dependencies:
perl-cross: arsv/perl-cross@f59d2b6 -> arsv/perl-cross@65e06e2

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
dependencies:
perl-cross: f59d2b6a179760230d925550db78b93c410433e4 -> 65e06e238ccb949e8399bdebc6d7fd798c34127b
@stigtsp
Copy link
Member Author

@stigtsp stigtsp commented Oct 22, 2020

@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.perldevel
@GrahamcOfBorg build pkgsCross.armv7l-hf-multiplatform.perldevel
@GrahamcOfBorg build pkgsMusl.perldevel
@GrahamcOfBorg build pkgsi686Linux.perldevel
@GrahamcOfBorg build perldevel

@stigtsp stigtsp requested review from aanderse and lopsided98 Oct 22, 2020
@stigtsp
Copy link
Member Author

@stigtsp stigtsp commented Oct 22, 2020

Cross non-devel perl:

@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.perl
@GrahamcOfBorg build pkgsCross.armv7l-hf-multiplatform.perl

@zakame
Copy link
Member

@zakame zakame commented Oct 22, 2020

Builds fine on my Slackware/Nix:

[nix-shell:~/.cache/nixpkgs-review/pr-101336]$ nix-info -m
 - system: `"x86_64-linux"`
 - host os: `Linux 4.4.240, Slackware, 14.2`
 - multi-user?: `no`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.3.7`
 - channels(zakame): `"nixpkgs-21.03pre246624.cfed29bfcb2"`
 - nixpkgs: `/home/zakame/.cache/nixpkgs-review/pr-101336/nixpkgs`

[nix-shell:~/.cache/nixpkgs-review/pr-101336]$ results/perldevel/bin/perl -V
Summary of my perl5 (revision 5 version 33 subversion 3) configuration:
   
  Platform:
    osname=linux
    osvers=gnulinux
    archname=x86_64-linux-thread-multi
    uname='linux x86_64 gnulinux '
    config_args='-de -Dcc=cc -Uinstallusrbinperl -Dinstallstyle=lib/perl5 -Duseshrplib -Dlocincpth=/no-such-path/include -Dloclibpth=/nix/store/bdf8iipzya03h2amgfncqpclf6bmy3a1-glibc-2.32/lib -Dusedevel -Uversiononly -Dusethreads -Dprefix=/nix/store/hicwxzmr2g0n4vbsrknv8hgmyhb5i8bs-perl-5.33.3 -Dman1dir=/nix/store/hicwxzmr2g0n4vbsrknv8hgmyhb5i8bs-perl-5.33.3/share/man/man1 -Dman3dir=/nix/store/hicwxzmr2g0n4vbsrknv8hgmyhb5i8bs-perl-5.33.3/share/man/man3'
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=define
    usemultiplicity=define
    use64bitint=define
    use64bitall=define
    uselongdouble=undef
    usemymalloc=n
    default_inc_excludes_dot=define
  Compiler:
    cc='cc'
    ccflags ='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/no-such-path/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'
    optimize='-O2'
    cppflags='-D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/no-such-path/include'
    ccversion=''
    gccversion='9.3.0'
    gccosandvers=''
    intsize=4
    longsize=8
    ptrsize=8
    doublesize=8
    byteorder=12345678
    doublekind=3
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=16
    longdblkind=3
    ivtype='long'
    ivsize=8
    nvtype='double'
    nvsize=8
    Off_t='off_t'
    lseeksize=8
    alignbytes=8
    prototype=define
  Linker and Libraries:
    ld='cc'
    ldflags =' -fstack-protector-strong -L/nix/store/bdf8iipzya03h2amgfncqpclf6bmy3a1-glibc-2.32/lib'
    libpth= 
    libs=-lpthread -ldl -lm -lcrypt -lutil -lc
    perllibs=-lpthread -ldl -lm -lcrypt -lutil -lc
    libc=
    so=so
    useshrplib=true
    libperl=libperl.so
    gnulibc_version='2.32'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=so
    d_dlsymun=undef
    ccdlflags='-Wl,-E -Wl,-rpath,/nix/store/hicwxzmr2g0n4vbsrknv8hgmyhb5i8bs-perl-5.33.3/lib/perl5/5.33.3/x86_64-linux-thread-multi/CORE'
    cccdlflags='-fPIC'
    lddlflags='-shared -O2 -L/nix/store/bdf8iipzya03h2amgfncqpclf6bmy3a1-glibc-2.32/lib -fstack-protector-strong'


Characteristics of this binary (from libperl): 
  Compile-time options:
    HAS_TIMES
    MULTIPLICITY
    PERLIO_LAYERS
    PERL_COPY_ON_WRITE
    PERL_DONT_CREATE_GVSV
    PERL_IMPLICIT_CONTEXT
    PERL_MALLOC_WRAP
    PERL_OP_PARENT
    PERL_PRESERVE_IVUV
    PERL_USE_DEVEL
    USE_64_BIT_ALL
    USE_64_BIT_INT
    USE_ITHREADS
    USE_LARGE_FILES
    USE_LOCALE
    USE_LOCALE_COLLATE
    USE_LOCALE_CTYPE
    USE_LOCALE_NUMERIC
    USE_LOCALE_TIME
    USE_PERLIO
    USE_PERL_ATOF
    USE_REENTRANT_API
    USE_THREAD_SAFE_LOCALE
  Built under linux
  Compiled at Oct 20 2020 19:49:48
  %ENV:
    PERL5LIB="/nix/store/hicwxzmr2g0n4vbsrknv8hgmyhb5i8bs-perl-5.33.3/lib/perl5/site_perl:/nix/store/hicwxzmr2g0n4vbsrknv8hgmyhb5i8bs-perl-5.33.3/lib/perl5/site_perl"
  @INC:
    /nix/store/hicwxzmr2g0n4vbsrknv8hgmyhb5i8bs-perl-5.33.3/lib/perl5/site_perl/5.33.3/x86_64-linux-thread-multi
    /nix/store/hicwxzmr2g0n4vbsrknv8hgmyhb5i8bs-perl-5.33.3/lib/perl5/site_perl/5.33.3
    /nix/store/hicwxzmr2g0n4vbsrknv8hgmyhb5i8bs-perl-5.33.3/lib/perl5/site_perl
    /nix/store/hicwxzmr2g0n4vbsrknv8hgmyhb5i8bs-perl-5.33.3/lib/perl5/site_perl/5.33.3/x86_64-linux-thread-multi
    /nix/store/hicwxzmr2g0n4vbsrknv8hgmyhb5i8bs-perl-5.33.3/lib/perl5/site_perl/5.33.3
    /nix/store/hicwxzmr2g0n4vbsrknv8hgmyhb5i8bs-perl-5.33.3/lib/perl5/site_perl
    /nix/store/hicwxzmr2g0n4vbsrknv8hgmyhb5i8bs-perl-5.33.3/lib/perl5/site_perl/5.33.3/x86_64-linux-thread-multi
    /nix/store/hicwxzmr2g0n4vbsrknv8hgmyhb5i8bs-perl-5.33.3/lib/perl5/site_perl/5.33.3
    /nix/store/hicwxzmr2g0n4vbsrknv8hgmyhb5i8bs-perl-5.33.3/lib/perl5/5.33.3/x86_64-linux-thread-multi
    /nix/store/hicwxzmr2g0n4vbsrknv8hgmyhb5i8bs-perl-5.33.3/lib/perl5/5.33.3

Result of nixpkgs-review pr 101336 1

1 package built:
  • perldevel

@stigtsp
Copy link
Member Author

@stigtsp stigtsp commented Oct 23, 2020

Built and tested OK on linux x64 and darwin x64

@stigtsp stigtsp merged commit eaadab0 into NixOS:master Oct 23, 2020
33 checks passed
33 checks passed
@github-actions
tests
Details
@github-actions
action
Details
@ofborg
pkgsCross.aarch64-multiplatform.perl on aarch64-linux Failure
Details
@ofborg
pkgsCross.aarch64-multiplatform.perldevel on aarch64-linux Failure
Details
@ofborg
pkgsMusl.perldevel on aarch64-linux Failure
Details
@ofborg
pkgsi686Linux.perldevel on aarch64-linux No attempt
Details
@ofborg
Evaluation Performance Report Evaluator Performance Report
Details
@github-actions
Wait for ofborg
Details
@ofborg
grahamcofborg-eval ^.^!
Details
@ofborg
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a07b4a0"; rev="a07b4a0017179e5a7727101576ccad4db8a86696"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a07b4a0"; rev="a07b4a0017179e5a7727101576ccad4db8a86696"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a07b4a0"; rev="a07b4a0017179e5a7727101576ccad4db8a86696"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a07b4a0"; rev="a07b4a0017179e5a7727101576ccad4db8a86696"; } ./nixos/
Details
@ofborg
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a07b4a0"; rev="a07b4a0017179e5a7727101576ccad4db8a86696"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a07b4a0"; rev="a07b4a0017179e5a7727101576ccad4db8a86696"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a07b4a0"; rev="a07b4a0017179e5a7727101576ccad4db8a86696"; } ./pkgs/t
Details
@ofborg
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg
perldevel on aarch64-linux Success
Details
@ofborg
perldevel on x86_64-linux Success
Details
@ofborg
perldevel, perldevel.passthru.tests on aarch64-linux Success
Details
@ofborg
perldevel, perldevel.passthru.tests on x86_64-linux Success
Details
@ofborg
pkgsCross.aarch64-multiplatform.perl on x86_64-linux Success
Details
@ofborg
pkgsCross.aarch64-multiplatform.perldevel on x86_64-linux Success
Details
@ofborg
pkgsCross.armv7l-hf-multiplatform.perl on aarch64-linux Success
Details
@ofborg
pkgsCross.armv7l-hf-multiplatform.perl on x86_64-linux Success
Details
@ofborg
pkgsCross.armv7l-hf-multiplatform.perldevel on aarch64-linux Success
Details
@ofborg
pkgsCross.armv7l-hf-multiplatform.perldevel on x86_64-linux Success
Details
@ofborg
pkgsMusl.perldevel on x86_64-linux Success
Details
@ofborg
pkgsi686Linux.perldevel on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants