Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linbox: backport upstream fixes #101382

Merged
merged 1 commit into from Nov 4, 2020
Merged

linbox: backport upstream fixes #101382

merged 1 commit into from Nov 4, 2020

Conversation

@omasanori
Copy link
Contributor

@omasanori omasanori commented Oct 22, 2020

Motivation for this change

This change backports part of the following upstream commits.

These patches are also backported by SageMath and required to build that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
    • sage still fails to build
    • doCheck = true and passes all tests.
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@omasanori
Copy link
Contributor Author

@omasanori omasanori commented Oct 22, 2020

Clarified TODO comments following @SuperSandro2000's comment. Thank you!
Removed unnecessary fetchpatch that had been used but I decided to patch only relevant files to minimize risks to introduce unintended side-effects.

@omasanori omasanori mentioned this pull request Oct 23, 2020
10 tasks
@omasanori
Copy link
Contributor Author

@omasanori omasanori commented Oct 26, 2020

Thank you for reviewing, @timokau! I will revise this PR.

References:
linbox-team/linbox@f78117d
linbox-team/linbox@4ff828e

Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
@omasanori
Copy link
Contributor Author

@omasanori omasanori commented Nov 4, 2020

Would you mind if I ask to review again and merge this?

timokau
timokau approved these changes Nov 4, 2020
Copy link
Member

@timokau timokau left a comment

Thanks for the reminder, I didn't realized that you already made the changes. Got lost in my inbox.

@timokau timokau merged commit 8201f4f into NixOS:master Nov 4, 2020
19 checks passed
@omasanori omasanori deleted the linbox-fix branch Nov 4, 2020
@omasanori
Copy link
Contributor Author

@omasanori omasanori commented Nov 4, 2020

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants